Cert rotation test does not use specific ingress namespace #15331
Conversation
knative-prow
bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
+ Coverage 84.78% 84.79% +0.01%
==========================================
Files 218 218
Lines 13504 13504
==========================================
+ Hits 11449 11451 +2
+ Misses 1688 1687 -1
+ Partials 367 366 -1 ☔ View full report in Codecov by Sentry. |
| @@ -225,12 +219,6 @@ func TestTLSCertificateRotation(t *testing.T) { | |||
| t.Fatalf("Failed to delete secret %s in system namespace: %v", config.ServingRoutingCertName, err) | |||
| } | |||
| checkEndpointState(t, clients, url) | |||
|
|
|||
| t.Log("Deleting secret in ingress namespace") | |||
| if err := clients.KubeClient.CoreV1().Secrets(ingressNS).Delete(context.Background(), config.ServingRoutingCertName, v1.DeleteOptions{}); err != nil { | |||
There was a problem hiding this comment.
It seems the error is: system_internal_tls_test.go:231: Failed to delete secret routing-serving-certs in ingress namespace: secrets "routing-serving-certs" not found. We could skip that error with if apierrs.IsNotFound(err) but I guess we want to keep upstream clean from the downstream assumptions.
There was a problem hiding this comment.
Right. I wanted to keep upstream clean. Thanks
|
/test ? |
|
@skonto: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test kourier-stable |
|
/test kourier-stable-tls |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/hold for tests |
knative-prow
bot
added
the
do-not-merge/hold
|
/test kourier-stable Unrelated error. |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Fixes #15276
Proposed Changes
routing-serving-certsare deployed in system namespace. This is where both Serving and Kourier controller expects them. The Serving components and Kourier might be possibly deployed in different system namespaces (like downstream) but in upstream it's the same namespace.Release Note