Adjust Workload HA test iterations to fit within test timeout #15362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15362 +/- ##
==========================================
- Coverage 84.59% 84.58% -0.02%
==========================================
Files 219 219
Lines 13584 13584
==========================================
- Hits 11492 11490 -2
- Misses 1725 1727 +2
Partials 367 367 ☔ View full report in Codecov by Sentry. |
dprotaso
force-pushed
the
debug-ha-workload
branch
from
ad5ae22 to
971a6ac
Compare
|
/retest |
|
/test istio-latest-no-mesh_serving_main |
dprotaso
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
izabelacg
reviewed
Jun 28, 2024
test/ha/workload_test.go
Outdated
| return false, nil | ||
| }, pod.Name, pod.Namespace); err != nil { | ||
| if !apierrs.IsNotFound(err) { | ||
| t.Fatalf("expected pkg to not be found") |
There was a problem hiding this comment.
just a minor thing. Did you mean pod instead of pkg?
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15360
I was debugging to see if there were any issues with this but I think it's just a timeout issue so reducing iterations should work.
Also did a minor refactor