Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestChangeDefaultDomain flake #15380

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 8, 2024

Was able to repro this on my machine

The test needs to eventually wait for the certificate to be deleted.

Fixes: #15364

/assign @EraKin575

Copy link

knative-prow bot commented Jul 8, 2024

@dprotaso: GitHub didn't allow me to assign the following users: EraKin575.

Note that only knative members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Was able to repro this on my machine

The test needs to eventually wait for the certificate to be deleted.

Fixes: #15364

/assign @EraKin575

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2024
@knative-prow knative-prow bot requested review from izabelacg and ReToCode July 8, 2024 21:01
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (ac7f585) to head (5f0bf0c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15380      +/-   ##
==========================================
- Coverage   84.58%   84.51%   -0.08%     
==========================================
  Files         219      219              
  Lines       13587    13587              
==========================================
- Hits        11493    11483      -10     
- Misses       1726     1733       +7     
- Partials      368      371       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link

knative-prow bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 306de5f into knative:main Jul 9, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flaky] pkg/reconciler/nscert: TestChangeDefaultDomain
2 participants