Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TLS test matrix #15394

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Update TLS test matrix #15394

merged 2 commits into from
Jul 15, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Jul 15, 2024

Fixes #15393.

Proposed Changes

  • Limit system-internal-tls tests to kourier/contour
  • Limit cluster-local-domain-tls tests to kourier/istio/contour

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2024
@knative-prow knative-prow bot requested review from izabelacg and skonto July 15, 2024 05:43
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@ReToCode ReToCode force-pushed the update-test-matrix branch from 32dc5c3 to dc2b06f Compare July 15, 2024 05:44
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (2156812) to head (f1ee782).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15394      +/-   ##
==========================================
+ Coverage   84.58%   84.60%   +0.02%     
==========================================
  Files         219      219              
  Lines       13587    13587              
==========================================
+ Hits        11492    11495       +3     
+ Misses       1726     1725       -1     
+ Partials      369      367       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode ReToCode changed the title Update TLS test matrix for istio and contour Update TLS test matrix Jul 15, 2024
@ReToCode
Copy link
Member Author

/assign @dprotaso

@ReToCode
Copy link
Member Author

/assign @skonto

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link

knative-prow bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 75310de into knative:main Jul 15, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants