Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cold start time increase issue #15479

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix cold start time increase issue #15479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/activator/net/revision_backends.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,11 @@ func (rw *revisionWatcher) checkDests(curDests, prevDests dests) {
if ok, err := rw.probeClusterIP(dest); err != nil {
rw.logger.Errorw("Failed to probe clusterIP "+dest, zap.Error(err))
} else if ok {
// We can reach here only iff pods are not successfully individually probed
// We can reach here only if pods are not successfully individually probed
// but ClusterIP conversely has been successfully probed.
rw.podsAddressable = false
if rw.meshMode == netcfg.MeshCompatibilityModeEnabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ReToCode thoughts on this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not sure about all the implications here. Last time I did dig down that rabbithole, this flag had more effects than just that.

Also, instead of setting this, probably Activator should rather watch that config and reconfigure instead of needing the restart.

rw.podsAddressable = false
}
rw.logger.Debugf("ClusterIP is successfully probed: %s (ready backends: %d)", dest, len(curDests.ready))
rw.clusterIPHealthy = true
rw.healthyPods = nil
Expand Down