Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow paths without a leading slash in probes #15681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow paths without a leading slash in probes #15681

wants to merge 1 commit into from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 10, 2025 •
edited
Loading

Fixes #15673

Proposed Changes

  • K8s allows that afaik so we should keep the UX.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (19b9a09) to head (0f8e118).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15681      +/-   ##
==========================================
+ Coverage   80.78%   80.83%   +0.04%     
==========================================
  Files         222      222              
  Lines       18025    18025              
==========================================
+ Hits        14561    14570       +9     
+ Misses       3092     3085       -7     
+ Partials      372      370       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor Author

skonto commented Jan 10, 2025 •
edited
Loading

I noticed this warning.

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@0c45773. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

cc @dprotaso is this a false positive as the version is v4.0.2?

@skonto
Copy link
Contributor Author

skonto commented Jan 10, 2025

/assign @dprotaso

@skonto skonto changed the title Allow paths without leading slash in probes Allow paths without a leading slash in probes Jan 10, 2025
@skonto
Copy link
Contributor Author

skonto commented Jan 14, 2025

@dprotaso gentle ping.

@skonto skonto added this to the v1.17.0 milestone Jan 14, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2025
@skonto skonto force-pushed the allow_paths_without_slash branch from 8821c8f to 0f8e118 Compare January 15, 2025 08:40
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
dprotaso
dprotaso reviewed Jan 16, 2025
View reviewed changes
pkg/queue/health/probe.go
@@ -111,7 +112,7 @@ var transport = func() *http.Transport {
}()

func getURL(config HTTPProbeConfigOptions) (*url.URL, error) {
return url.Parse(string(config.Scheme) + "://" + net.JoinHostPort(config.Host, config.Port.String()) + config.Path)
return url.Parse(string(config.Scheme) + "://" + net.JoinHostPort(config.Host, config.Port.String()) + "/" + strings.TrimPrefix(config.Path, "/"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just construct a URL struct instead of building a url string and then parsing it.

eg. url.URL handles normalizing the url - see: https://go.dev/play/p/BC7UV63Drih

u1 = url.URL{
	Scheme: "http",
	Path:   "/blah",
	Host:   net.JoinHostPort("host", "port"),
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh and lets add a unit test so we don't regress in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

@izabelacg izabelacg Awaiting requested review from izabelacg

@salaboy salaboy Awaiting requested review from salaboy

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

Regression in readiness path handling causes parsing error
3 participants
@skonto @dprotaso @knative-prow-robot