Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix builds on arm/v7 #15699

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix builds on arm/v7 #15699

merged 1 commit into from
Jan 16, 2025

Conversation

dprotaso
Copy link
Member

Fixes our broken nightly release build

@dprotaso
Copy link
Member Author

/assign @skonto

Copy link

knative-prow bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2025
@knative-prow knative-prow bot requested review from izabelacg and skonto January 16, 2025 14:51
@skonto
Copy link
Contributor

skonto commented Jan 16, 2025

/lgtm
/aprrove

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (c3f2bfe) to head (6c0b2b4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15699      +/-   ##
==========================================
+ Coverage   80.76%   80.83%   +0.06%     
==========================================
  Files         222      222              
  Lines       18025    18025              
==========================================
+ Hits        14558    14570      +12     
+ Misses       3094     3085       -9     
+ Partials      373      370       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/retest

@knative-prow knative-prow bot merged commit 5ede174 into knative:main Jan 16, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants