Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Ensure ContainerHealthy condition is set back to True #15712

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #15503

A revision is now set to ContainerHealthy=True when it has ready replicas

Co-authored-by: Matthias Diester <[email protected]>
Signed-off-by: Sascha Schwarze <[email protected]>
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2025
@knative-prow knative-prow bot requested review from izabelacg and skonto January 20, 2025 22:12
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link

knative-prow bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.51%. Comparing base (b17688f) to head (3a626aa).
Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/testing/functional.go 62.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16   #15712      +/-   ##
================================================
- Coverage         83.56%   83.51%   -0.05%     
================================================
  Files               219      219              
  Lines             17427    17455      +28     
================================================
+ Hits              14563    14578      +15     
- Misses             2494     2505      +11     
- Partials            370      372       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/override "test (v1.28.x, kourier-tls, runtime)"

Copy link

knative-prow bot commented Jan 20, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.28.x, kourier-tls, runtime)

In response to this:

/override "test (v1.28.x, kourier-tls, runtime)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 06bb3a7 into knative:release-1.16 Jan 20, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants