Introduced KNULLI flag, hid some irrelevant menu options, added RGB sanity check #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to decline PR #23 since commenting out code instead of disabling it properly is a bad idea. I introduced a new
KNULLIflag that can be checked for withifdefandifndefand used this mechanic to hide a couple of menus/options, including the ones proposed in PR #23.Additionally, I added an RGB settings sanity check because some user ran into an issue with the menu not opening due to a mode being configured in
batocera.confthat wasn't available any more for their device.Be aware of the corresponding PR in Knulli distribution: knulli-cfw/distribution#277