Hide empty collection on users profile

[onerawartist]

What happened?

i used ( extra > Admin panel ) to consume the collection i created by mistake but its still here:

https://nft.kodadot.xyz/rmrk/collection/FC77C33AB229A2056A-THECUBE
all the nfts in it are gone, but it is still shown in my profile

Please reproduce in steps

/

Expected Behavior

to not be shown in my profile

What browsers are you seeing the problem on?

Chrome

Are you logged in?

Yes

At which address did you encounter bug?

nft.kodadot.xyz / kodadot.xyz

Screenshots

---

Relevant log output

/

Code of Conduct

• I agree to follow this project's Code of Conduct

[onerawartist]

the collection doesn't show up in ( extra > Admin panel ), but its still there in my profile when i see " collections "

[onerawartist]

when i visited my profile through singular i don't see the collection i removed using Admin panel

[vikiival]

Hey, according to the implementation standards of RMRK you cannot delete the collection.

the collection doesn't show up

We do not want to show people empty collections in admin panel (as you can't do any action)

[onerawartist]

@vikiival im not saying there's something wrong with admin panel,
I created a collection , added some nfts in it
Then i used the admin panel to consume the nfts,
The result should be: the empty collection not showing up in my profile.
There must be a hack around , to hide collections when they become empty

[onerawartist]

I don't want all the tutorials showing up in my profile in the future.
Change the option in profiles , to only show a collection if it has an nft in it or more.
And stay invisible if its empty
@vikiival @yangwao

[onerawartist]

[onerawartist]

kodadot shows the empty collection, while singular don't, i really think you should add feature to kodadot

[roiLeo]

#1357 related

[onerawartist]

@yangwao , can't we try to fix this one first? then work on #1357 . because this looks like a simple thing to do, to just hide the empty collections ?

[kkukelka]

this can only be solved on the api-level through rewriting the respective resolver for the "collectionListWithSearch" query, since graphql queries cant filter out items with empty arrays in one of their properties

[vikiival]

Ref kodadot/magick#11

[onerawartist]

@vikiival @yangwao
can you also hide the number of the consumed nfts , from the collection statistics ?
i removed most of the nfts , because you guys added the thumbnail option, so i burned all my nfts , and minted them again, but when the statistics are shown like that , it gives bad image to the collection and to me

[onerawartist]

Hide empty collections and hide consumed nfts from collection statistics

[onerawartist]

@vikiival @yangwao i'm hating how my profile is looking :( , when can we get this feature ?

[yangwao]

Hey, according to the implementation standards of RMRK you cannot delete the collection.

the collection doesn't show up

We do not want to show people empty collections in admin panel (as you can't do any action)

Well, you mean floating RMRK standard, yah? :D

I mean, let's add KODA::HIDE or something like that! :) later we can evolve into zkHIDE ;D

[onerawartist]

im still waiting for this to be solved because i hate how my profile looks right now lol , its a mess.

@yangwao @vikiival @XyloDrone @kkukelka please help

[XyloDrone]

Explorer has been redesigned, profile in the works, landing page is a priority atm :)

[vikiival]

As @XyloDrone asked me if we could do that asap @roiLeo opened issue months ago

[vikiival]

So the correct answer for this issue is:

1. Rework query from SubQuery to Subsquid (made for you)
   **PLEASE NOTE THAT THIS NEW QUERY HAS TO GO UNDER queries/rmrk/subsquid directory.

query collectionListByAccount($account: String!, $first: Int!, $offset: Int) {
  collectionEntities(where: {issuer_eq: $account, nfts_some: {}}, orderBy: blockNumber_DESC, limit: $first, offset: $offset) {
    ...collection
    ...collectionDetails
  }
}

2. change client from SubQuery to SubSquid
   in ProfileDetail.vue line 318 change the value to subsquid
3. updated handleCollectionResult accordingly

I heard @Jarsen136 wanted to pick that up :)

[Jarsen136]

So the correct answer for this issue is:

1. Rework query from SubQuery to Subsquid (made for you)
   **PLEASE NOTE THAT THIS NEW QUERY HAS TO GO UNDER queries/rmrk/subsquid directory.

query collectionListByAccount($account: String!, $first: Int!, $offset: Int) {
  collectionEntities(where: {issuer_eq: $account, nfts_some: {}}, orderBy: blockNumber_DESC, limit: $first, offset: $offset) {
    ...collection
    ...collectionDetails
  }
}

2. change client from SubQuery to SubSquid
   in ProfileDetail.vue line 318 change the value to subsquid
3. updated handleCollectionResult accordingly

I heard @Jarsen136 wanted to pick that up :)

Well, I will have a try later!

[Jarsen136]

query collectionListByAccount($account: String!, $first: Int!, $offset: Int) {
  collectionEntities(where: {issuer_eq: $account, nfts_some: {}}, orderBy: blockNumber_DESC, limit: $first, offset: $offset) {
    ...collection
    ...collectionDetails
  }
}

this Subsquid seem not works well as it return all collections including the one with consumed nfts.
I think we need to do some change on nfts_some: {}
Could you give me some help? @vikiival

I test it on the account: /rmrk/u/JHMAL5CyvxWc3Ud42QxRUTpSnUa4m56mRSzPK69d1TU8NG7?tab=collection
request payload:

responce:

[vikiival]

Good catch!

query collectionListByAccount($account: String!, $first: Int!, $offset: Int) {
  collectionEntities(where: {issuer_eq: $account, nfts_some: { burned_eq: false }}, orderBy: blockNumber_DESC, limit: $first, offset: $offset) {
    ...collection
    ...collectionDetails
  }
}

also do not be confused with max: 0 it means that the collection is infinite :) (B ❤️ PHP)