Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: Footer #3948

Closed
Tracked by #3950
prachi00 opened this issue Sep 13, 2022 · 15 comments · Fixed by #4016
Closed
Tracked by #3950

Redesign: Footer #3948

prachi00 opened this issue Sep 13, 2022 · 15 comments · Fixed by #4016
Labels
$ ~<50usd enhancement New feature or request p2 core functionality, or is affecting 60% of app redesign

Comments

@prachi00
Copy link
Member

prachi00 commented Sep 13, 2022

parent task: #3844

Quoting original issue:

Here we will collect email address into our Substack.
Link Substack of our Kodadot publication, can drop code for button
Other links are to

FAQ -> https://kodadot.xyz/rmrk/faq -> probably we should move FAQ to root, like https://kodadot.xyz/faq
Grants -> link to current grants form
Documentation -> https://docs.kodadot.xyz/
Contribute -> https://kodadot.xyz/contribute
Socials
Twitter -> https://twitter.com/kodadot
Instagram -> https://instagram/kodadot.xyz
Discord -> https://discord.gg/u6ymnbz4PR
Youtube
Telegram

Screen Shot 2022-09-12 at 6 32 44 PM

@prachi00 prachi00 added the enhancement New feature or request label Sep 13, 2022
@prachi00 prachi00 self-assigned this Sep 13, 2022
@kodabot
Copy link
Collaborator

kodabot commented Sep 13, 2022

ASSIGNED - @prachi00 🔒 LOCKED -> Wednesday, September 14th 2022, 13:33:32 UTC -> 36 hours

@prachi00 prachi00 changed the title Redesign: Featured Articles Redesign: Footer Sep 13, 2022
@prachi00
Copy link
Member Author

@preschian @roiLeo I see we don't have any common scss variables set yet for the new common colors like #6188E7 , I can ho ahead and set all the new colours in _variables.scss in this PR if it sounds good to you?

@prachi00
Copy link
Member Author

@yangwao in the design I only see some options under the Kodadot heading
are we removing the others not mentioned like

  • Carrers
  • Ambassador Programs
  • Press kit
  • QR

@yangwao
Copy link
Member

yangwao commented Sep 13, 2022

  • Carrers
  • Ambassador Programs
  • Press kit

Let's keep these ones :)

@preschian
Copy link
Member

@preschian @roiLeo I see we don't have any common scss variables set yet for the new common colors like #6188E7 , I can ho ahead and set all the new colours in _variables.scss in this PR if it sounds good to you?

of course, sounds good to me 👌

@prachi00
Copy link
Member Author

Link Substack of our Kodadot publication, can drop code for button
@yangwao can you explain this one more?

@kodabot
Copy link
Collaborator

kodabot commented Sep 14, 2022

ASSIGNMENT EXPIRED - @prachi00 has been unassigned.

@prachi00
Copy link
Member Author

prachi00 commented Sep 20, 2022

@roiLeo for css, I am facing one issue, we already have overriding classes for some tags like <a anchor tag, , input so even if I override it, its not applying, the only solution is to remove the old ones but then it would break the current UI
LMYWYT

@prachi00
Copy link
Member Author

Link Substack of our Kodadot publication, can drop code for button @yangwao can you explain this one more?

@yangwao

@roiLeo
Copy link
Contributor

roiLeo commented Sep 21, 2022

@roiLeo for css, I am facing one issue, we already have overriding classes for some tags like <a anchor tag, , input so even if I override it, its not applying, the only solution is to remove the old ones but then it would break the current UI LMYWYT

It's an old relic from the past.
Put your css rule inside .footer and it will override them?

Don't hesitate to push your code so we can see what's wrong.
I just thought that the new footer will be visible on all pages like the new searchbar.

@yangwao
Copy link
Member

yangwao commented Sep 23, 2022

Hey, @prachi00 can you please push what you have so we can speed up things on this?

@yangwao
Copy link
Member

yangwao commented Sep 23, 2022

Link Substack of our Kodadot publication, can drop code for button
@yangwao can you explain this one more?

https://support.substack.com/hc/en-us/articles/360041759232-Can-I-embed-a-signup-form-for-my-publication-

but struggle to find HTML code

@yangwao
Copy link
Member

yangwao commented Sep 23, 2022

oh probably only iframe is current way to do it?
this is our substack we want to link up https://kodadot.substack.com

https://codepen.io/OceanSquad/pen/rNaoddK

<iframe width="50%" height="320" src="https://kodadot.substack.com/embed" frameborder="0" scrolling="no"></iframe>

@yangwao yangwao added the p2 core functionality, or is affecting 60% of app label Sep 23, 2022
prachi00 added a commit that referenced this issue Sep 23, 2022
@prachi00 prachi00 mentioned this issue Sep 23, 2022
18 tasks
prachi00 added a commit that referenced this issue Sep 23, 2022
@prachi00
Copy link
Member Author

oh probably only iframe is current way to do it? this is our substack we want to link up https://kodadot.substack.com

https://codepen.io/OceanSquad/pen/rNaoddK

<iframe width="50%" height="320" src="https://kodadot.substack.com/embed" frameborder="0" scrolling="no"></iframe>

yeah seems like it isnt customizable, does this look okay to you? this is the iframe embedded
Screen Shot 2022-09-23 at 11 56 47 AM

prachi00 added a commit that referenced this issue Sep 23, 2022
@prachi00
Copy link
Member Author

@yangwao we can try the 1st method as well here for custom it seems
https://docs.substackapi.com/add-your-substack-signup-form-to-your-website

prachi00 added a commit that referenced this issue Sep 29, 2022
prachi00 added a commit that referenced this issue Oct 2, 2022
prachi00 added a commit that referenced this issue Oct 4, 2022
prachi00 added a commit that referenced this issue Oct 6, 2022
prachi00 added a commit that referenced this issue Oct 7, 2022
petersopko added a commit that referenced this issue Oct 7, 2022
@yangwao yangwao mentioned this issue Oct 28, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
$ ~<50usd enhancement New feature or request p2 core functionality, or is affecting 60% of app redesign
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants