#3948 Footer redesign #4016

prachi00 · 2022-09-23T18:17:24Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR closes Redesign: Footer #3948
Requires deployment <rubick/magick_issue>
<brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address:
Payout

Community participation

Are you at KodaDot Discord?

Screenshot

My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify · 2022-09-23T18:17:27Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`ad799fa`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/633fec231d8b9b00085156b2
😎 Deploy Preview	https://deploy-preview-4016--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kodabot · 2022-09-23T18:17:28Z

WARNING @prachi00 PR for issue #3948 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3948

prachi00 · 2022-09-23T18:17:55Z

Left:

INPUT - working on this

vikiival · 2022-09-24T09:10:58Z

🫣

roiLeo

On OSX 13-inch:

preview

figma

Could you please use Columns as it would help to make the footer responsive
And also remove single quote changes for .scss files

yangwao · 2022-09-25T16:58:44Z

we just had a call @exezbcz that will update Figma with new footer where we put two columns as current one breaks on mobile interface :)

exezbcz · 2022-09-28T14:09:35Z

Hey @prachi00 @roiLeo, I redesigned the footer and added columns, it's updated in Figma, second page - design, under the landing page. There is also a mobile version. Thanks and sorry for the delay.

prachi00 · 2022-09-28T19:49:50Z

Hey @prachi00 @roiLeo, I redesigned the footer and added columns, it's updated in Figma, second page - design, under the landing page. There is also a mobile version. Thanks and sorry for the delay.

I'll update

prachi00 · 2022-09-29T03:11:50Z

@yangwao @roiLeo

also what are we doing about the iframe, as I am not sure if there is other way to handle it

prachi00 · 2022-09-29T03:34:35Z

@roiLeo also using columns is creating spacing differences from figma and we anyway have to give extra css to override those, so I was thinking of manually doing the responsive for this, its easier

exezbcz · 2022-10-02T07:38:58Z

This is how the colors should look in dark mode. In white mode, the buttons work the same as for example selection of timeframe in top collections. It's consistent with the whole design/system.
White mode buttons (the middle button is on hover)

prachi00 · 2022-10-03T05:54:47Z

This is how the colors should look in dark mode. In white mode, the buttons work the same as for example selection of timeframe in top collections. It's consistent with the whole design/system. White mode buttons (the middle button is on hover)

okay makes sense, thank you

roiLeo

Hey! Substack input looks better.
Found small things:

From Figma file, footer should be wrapped in .container class (check landing div/section wrapper)

Enregistrement.de.l.ecran.2022-10-03.a.8.33.03.AM.mov

cursor on hover state on social link are working only on icon and not on the button

include icon in hover state

roiLeo

Feel free to migrate TheFooter component to Vue3 way

components/TheFooter.vue

prachi00 · 2022-10-06T01:38:57Z

Feel free to migrate TheFooter component to Vue3 way

are we upgrading?

roiLeo

Feel free to migrate TheFooter component to Vue3 way

are we upgrading?

Slowly but yeah!

One last small thing:

social icon hover state on dark-mode

package.json

roiLeo

✅ lgtm, scss might need some refacto

codeclimate · 2022-10-07T09:07:10Z

Code Climate has analyzed commit ad799fa and detected 0 issues on this pull request.

View more on Code Climate.

petersopko

✅

petersopko · 2022-10-07T09:10:23Z

pay 100 usd

yangwao · 2022-10-07T09:10:36Z

😍 Perfect, I’ve sent the payout
💵 $100 @ 43.39 USD/KSM ~ 2.305 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x3a7f3c1b5770fc544d1d447079b9adf5e658c72ae6ec1c6ee924806f27176a42

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

#3948 Footer redesign

cb1c09f

prachi00 requested review from a team as code owners September 23, 2022 18:17

prachi00 requested review from Jarsen136 and petersopko and removed request for a team September 23, 2022 18:17

prachi00 requested a review from roiLeo September 23, 2022 18:17

prachi00 added 2 commits September 23, 2022 11:48

#3948 Footer button UI

abf8baa

#3948 Iframe for subs

0fc498c

prachi00 changed the title ~~WIP: #3948 Footer redesign~~ #3948 Footer redesign Sep 23, 2022

prachi00 requested review from yangwao, preschian and vikiival September 23, 2022 19:00

roiLeo suggested changes Sep 24, 2022

View reviewed changes

yangwao removed request for preschian, vikiival and Jarsen136 September 25, 2022 16:54

Merge branch 'main' into feat-new-footer

96eb4ff

prachi00 and others added 2 commits September 28, 2022 20:40

#3948 ui changes for footer

a3bdd69

Merge branch 'main' into feat-new-footer

53a6c87

prachi00 requested a review from roiLeo October 3, 2022 05:55

roiLeo reviewed Oct 3, 2022

View reviewed changes

yangwao added the redesign label Oct 3, 2022

prachi00 and others added 2 commits October 3, 2022 18:34

#3948 minor chnages

fdc277b

Merge branch 'main' into feat-new-footer

0496764

prachi00 requested a review from roiLeo October 4, 2022 01:34

roiLeo reviewed Oct 4, 2022

View reviewed changes

components/TheFooter.vue Outdated Show resolved Hide resolved

components/TheFooter.vue Outdated Show resolved Hide resolved

components/TheFooter.vue Outdated Show resolved Hide resolved

components/TheFooter.vue Outdated Show resolved Hide resolved

#3948 more cleanup

841b97f

prachi00 closed this Oct 6, 2022

prachi00 reopened this Oct 6, 2022

Merge branch 'main' into feat-new-footer

25f2364

roiLeo reviewed Oct 6, 2022

View reviewed changes

#3948 dark mode hover issue

aaf78db

roiLeo reviewed Oct 7, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

roiLeo added 2 commits October 7, 2022 08:50

Update package.json

141261f

Merge branch 'main' into feat-new-footer

b44a733

roiLeo approved these changes Oct 7, 2022

View reviewed changes

Merge branch 'main' into feat-new-footer

ad799fa

petersopko approved these changes Oct 7, 2022

View reviewed changes

yangwao added the paid pull-request has been paid label Oct 7, 2022

petersopko merged commit 44e4160 into main Oct 7, 2022

petersopko deleted the feat-new-footer branch October 7, 2022 09:39

petersopko added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Oct 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3948 Footer redesign #4016

#3948 Footer redesign #4016

prachi00 commented Sep 23, 2022 •

edited

Loading

netlify bot commented Sep 23, 2022 •

edited

Loading

kodabot commented Sep 23, 2022

prachi00 commented Sep 23, 2022 •

edited

Loading

vikiival commented Sep 24, 2022

roiLeo left a comment

yangwao commented Sep 25, 2022

exezbcz commented Sep 28, 2022

prachi00 commented Sep 28, 2022

prachi00 commented Sep 29, 2022

prachi00 commented Sep 29, 2022

exezbcz commented Oct 2, 2022

prachi00 commented Oct 3, 2022

roiLeo left a comment •

edited

Loading

roiLeo left a comment

prachi00 commented Oct 6, 2022

roiLeo left a comment

roiLeo left a comment

codeclimate bot commented Oct 7, 2022

petersopko left a comment

petersopko commented Oct 7, 2022

yangwao commented Oct 7, 2022

#3948 Footer redesign #4016

#3948 Footer redesign #4016

Conversation

prachi00 commented Sep 23, 2022 • edited Loading

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

netlify bot commented Sep 23, 2022 • edited Loading

✅ Deploy Preview for koda-nuxt ready!

kodabot commented Sep 23, 2022

prachi00 commented Sep 23, 2022 • edited Loading

vikiival commented Sep 24, 2022

roiLeo left a comment

Choose a reason for hiding this comment

yangwao commented Sep 25, 2022

exezbcz commented Sep 28, 2022

prachi00 commented Sep 28, 2022

prachi00 commented Sep 29, 2022

prachi00 commented Sep 29, 2022

exezbcz commented Oct 2, 2022

prachi00 commented Oct 3, 2022

roiLeo left a comment • edited Loading

Choose a reason for hiding this comment

roiLeo left a comment

Choose a reason for hiding this comment

prachi00 commented Oct 6, 2022

roiLeo left a comment

Choose a reason for hiding this comment

roiLeo left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 7, 2022

petersopko left a comment

Choose a reason for hiding this comment

petersopko commented Oct 7, 2022

yangwao commented Oct 7, 2022

prachi00 commented Sep 23, 2022 •

edited

Loading

netlify bot commented Sep 23, 2022 •

edited

Loading

prachi00 commented Sep 23, 2022 •

edited

Loading

roiLeo left a comment •

edited

Loading