Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SearchBar): Show price range next to the filter #2403

Merged
merged 6 commits into from
Feb 21, 2022
Merged

feat(SearchBar): Show price range next to the filter #2403

merged 6 commits into from
Feb 21, 2022

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Feb 19, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed sticky header in series and spotlight on UI; a screenshot is best to understand changes for others.

20220219152144

@netlify
Copy link

netlify bot commented Feb 19, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 93c38bd

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/621140cada29a600082aae6e

😎 Browse the preview: https://deploy-preview-2403--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Feb 19, 2022

hey, this issue should follow after this one #2398

if you can fetch changes from that PR into yours

It's meanwhile merged in main

@yangwao
Copy link
Member

yangwao commented Feb 19, 2022

Hey @zhengow this doesn't seems to be fixed well
image

@zhengow
Copy link
Contributor Author

zhengow commented Feb 19, 2022

I change the text position and now it looks like this:
image

plz review again.
btw, what device do u use to check? and what's the screen resolution?

@yangwao
Copy link
Member

yangwao commented Feb 19, 2022

It should be next to the filter.
You've made it under filter. :)

It was made on desktop

@zhengow
Copy link
Contributor Author

zhengow commented Feb 19, 2022

fix the postion to "next to"
now it looks like this:

price_show.mp4

plz review again :)

@yangwao
Copy link
Member

yangwao commented Feb 21, 2022

okay let's go! :)

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Feb 21, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 138.87 USD/KSM ~ 0.72 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0x0ba82161c726d9d5cdca69fb032e85df969f216c1b89a06d57ecdacb75b31682

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 21, 2022
@yangwao yangwao merged commit 1f32852 into kodadot:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show price range next to the filter
2 participants