Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2420 - fix searchbar on mobile #2430

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

petersopko
Copy link
Contributor

@petersopko petersopko commented Feb 22, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
KodaDot.-.Kusama.NFT.Market.Explorer._.Low.Carbon.NFTs.-.Google.Chrome.2022-02-22.18-07-27.mp4

@netlify
Copy link

netlify bot commented Feb 22, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: 3aeb814

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/621d01878399580007e54c36

😎 Browse the preview: https://deploy-preview-2430--koda-nuxt.netlify.app

@yangwao
Copy link
Member

yangwao commented Feb 28, 2022

#2425 was merged, you've got green runway ;)

@petersopko
Copy link
Contributor Author

I've changed the order of text in search section, in my opinion this still wasn't good:
image
Here's the current version:

Low.minting.fees.and.carbonless.NFTs._.Low.Carbon.NFTs.-.Google.Chrome.2022-02-28.18-02-48.mp4

@petersopko petersopko marked this pull request as ready for review February 28, 2022 17:08
@petersopko
Copy link
Contributor Author

@yangwao I've kept the search bar located in the navbar in case of collections instead of what I've described in #2420 since I've mistakenly thought that the searchbar located in navbar is "collections" on collections page. Since in navbar there's always only "gallery", it makes sense to keep it there. The gallery is fixed here, tomorrow I'll start looking into the unification of Gallery/Collections search experience.

Low.minting.fees.and.carbonless.NFTs._.Low.Carbon.NFTs.-.Google.Chrome.2022-02-28.18-15-10.mp4

@yangwao
Copy link
Member

yangwao commented Feb 28, 2022

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Feb 28, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 123.91 USD/KSM ~ 0.807 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0x18c4b4defd1c60ca878a33361c45b08bc16b946841bf145773d120a28b895d02

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Feb 28, 2022
@yangwao yangwao merged commit e6e7a2f into kodadot:main Feb 28, 2022
@petersopko petersopko mentioned this pull request Mar 8, 2022
17 tasks
@petersopko petersopko deleted the 2420-fix_searchbar_on_mobile branch September 13, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix searchbar on mobile
2 participants