-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite scroll for all views #2859
Merged
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e041a40
explore gallery infinite scroll
Jarsen136 d6d7676
NFTEntityOrderByInput
Jarsen136 a15ea51
chroe: recover onResize
Jarsen136 4615f50
items in collection scroll
Jarsen136 2455471
fix switch tab
Jarsen136 7ae91dc
fix sortby net error
Jarsen136 67a535a
profile page infinite scroll
Jarsen136 e3ac41c
fix tile mode on collection page
Jarsen136 edba7d4
Merge branch 'main' into issue-1582-infinite-scroll
Jarsen136 430551c
Merge branch 'issue-2860' into issue-1582-infinite-scroll
Jarsen136 daaa2aa
fetchPageData refactor
Jarsen136 df31303
Merge branch 'main' into issue-1582-infinite-scroll
Jarsen136 2ac05ec
transfrom kebab-case to PascalCase
Jarsen136 b26649d
Merge branch 'main' into issue-1582-infinite-scroll
Jarsen136 a93764d
fix: check cur page is valid
Jarsen136 d84f344
Merge branch 'issue-1582-infinite-scroll' of github.com:Jarsen136/nft…
Jarsen136 b350763
Merge branch 'main' into issue-1582-infinite-scroll
yangwao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why u changed that from function to object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
$apollo.query
needvariables
to be an object.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
https://apollo.vuejs.org/guide/apollo/queries.html#reactive-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://apollo.vuejs.org/guide/apollo/queries.html#option-function
https://apollo.vuejs.org/guide/apollo/queries.html#reactive-query-definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both
function
andobject
could work.However, the query does not need to be 'reactive' in this case.
So I use the object to be the param. 🤔
And if you have other reasons to use 'function', I could change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed my mind after doing some tries, because using
function
asvariables
could not work.$apollo.query
only accept 'object' in this case.