Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: page locate index #2931

Merged
merged 4 commits into from
May 5, 2022
Merged

feat: page locate index #2931

merged 4 commits into from
May 5, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented May 1, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

I think the comment could be resolved via #2859 (comment)

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 1, 2022 09:16
@Jarsen136 Jarsen136 requested review from roiLeo and removed request for a team May 1, 2022 09:16
@kodabot
Copy link
Collaborator

kodabot commented May 1, 2022

WARNING @Jarsen136 PR for issue #2921 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #2921

@netlify
Copy link

netlify bot commented May 1, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9569d70
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62737cbd77b109000811677a
😎 Deploy Preview https://deploy-preview-2931--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao mentioned this pull request May 1, 2022
1 task
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Test behaviour on mobile

Ok, next we could try to load less data for mobile user

  • Sharing page if it opens on new window well even on mobile

Not sure it's working as excepted

  • Different content between pages

same

components/rmrk/Gallery/Gallery.vue Outdated Show resolved Hide resolved
utils/mixins/infiniteScrollMixin.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on /rmrk/explore/?tab=COLLECTION
Capture d’écran 2022-05-04 à 9 05 58 AM
This button doesn't work anymore on your branch

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented May 4, 2022

This button doesn't work anymore on your branch

Thanks for noticing that.

Already fixed.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this one for now

  • Test behaviour on mobile
  • Sharing page if it opens on new window well even on mobile
  • Different content between original page and new window page for same URL

@roiLeo
Copy link
Contributor

roiLeo commented May 5, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented May 5, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 142.51 USD/KSM ~ 0.351 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x27c1dd10676add8b9e3816204e47be526602cf68cf2f8873c765686f57fe00cd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label May 5, 2022
@roiLeo roiLeo merged commit 3f303b2 into kodadot:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up: Infinite scroll v2
4 participants