Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove search query from url when empty #3093

Merged
merged 6 commits into from
Jun 3, 2022
Merged

fix: remove search query from url when empty #3093

merged 6 commits into from
Jun 3, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@Jarsen136 Jarsen136 requested a review from a team as a code owner May 31, 2022 13:36
@Jarsen136 Jarsen136 requested review from roiLeo and removed request for a team May 31, 2022 13:36
@kodabot
Copy link
Collaborator

kodabot commented May 31, 2022

SUCCESS @Jarsen136 PR for issue #3092 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented May 31, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit ca4ac45
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/629a4b7f8897a10008776229
😎 Deploy Preview https://deploy-preview-3093--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roiLeo
roiLeo approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ can't reproduce empty search, code lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jun 2, 2022
@prachi00
Copy link
Member

prachi00 commented Jun 3, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Jun 3, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 69.06 USD/KSM ~ 0.724 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x2cb8d676e9d4b723c230bc9ab544c0a49a2dbc28610f2f8cfe6cabd441af9285

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 3, 2022
@prachi00 prachi00 merged commit acc5c26 into kodadot:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove search query from url when empty
5 participants
@Jarsen136 @kodabot @prachi00 @yangwao @roiLeo