Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2775 Adding popular collections to landing #3102

Merged
merged 3 commits into from
Jun 4, 2022
Merged

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jun 4, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-06-03 at 6 18 33 PM

@prachi00 prachi00 requested a review from a team as a code owner June 4, 2022 01:19
@prachi00 prachi00 requested review from kkukelka and removed request for a team June 4, 2022 01:19
@netlify
Copy link

netlify bot commented Jun 4, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit df0147f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/629b0a09c592b70009fdb085
😎 Deploy Preview https://deploy-preview-3102--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just 2 comments

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kkukelka kkukelka merged commit 54452cc into main Jun 4, 2022
@kkukelka kkukelka deleted the feat-popular-collections branch June 4, 2022 07:37
@kkukelka
Copy link
Member

kkukelka commented Jun 4, 2022

pay 100

@yangwao
Copy link
Member

yangwao commented Jun 4, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 68.24 USD/KSM ~ 1.465 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x990260e498c20c2e3f547434246d738daa002bbe94c526f0c3c3ec6db85cfbe8

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show popular trending collection on landing
3 participants