-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesign: prepare landing page for new design #3895
Conversation
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hi, I need your feedback, should we go with this approach or not? the goal is, we can start redesigning components without blocking deployment to production. because the new design only can be accessed with query parameters alternative from query parameters:
|
wait what? why this way? |
I thought this way was easier. but if we already have another simpler solution I will follow it 👍 |
for this, does it means we have another big branch for a redesign? for example |
yes! maybe with another branch name, since we're migrating app to use vue3 composition api |
I thought that with another big branch would be difficult once ready to merge into the main branch, because of some file conflicts but, no issue for me if everyone prefers that way 👍 |
Let's wait for another developer's point of view |
Since we're going to use new typo, different font-size & update components (inputs, select, dropdown) design. I would be in favor to make these developments on a new branch so as not to disrupt the existing one. |
maybe describe and define the branch name in here #3710. so on every redesign PR can follow the guideline to that link |
I've dropped some wisdom #3710
just for the landing page, I promise 🤞🥹 |
ready for review 🙏🏻 it's decided that we use query parameters for the landing page only #3710 (reply in thread). the goal is still the same, hopefully not break/block the existing design while creating a new redesign component |
Code Climate has analyzed commit 31f693d and detected 0 issues on this pull request. View more on Code Climate. |
yas, let's kick this off! :) works old version and the new one seems div containers ready to be there. pay 100 |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
?redesign=true
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot