Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: prepare landing page for new design #3895

Merged
merged 4 commits into from
Sep 10, 2022
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Sep 1, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Sep 1, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 31f693d
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63197a4932797b00083c2293
😎 Deploy Preview https://deploy-preview-3895--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian changed the title redesign: landing page for new design redesign: prepare landing page for new design Sep 1, 2022
@preschian preschian marked this pull request as ready for review September 1, 2022 11:33
@preschian preschian requested review from a team as code owners September 1, 2022 11:33
@preschian preschian requested review from kkukelka, damskyftw, roiLeo, vikiival, yangwao and petersopko and removed request for a team September 1, 2022 11:33
@preschian
Copy link
Member Author

preschian commented Sep 1, 2022

hi, I need your feedback, should we go with this approach or not? the goal is, we can start redesigning components without blocking deployment to production. because the new design only can be accessed with query parameters

#3710 (comment)

alternative from query parameters:

  • custom cookie
  • custom http-header
  • env variable

@roiLeo
Copy link
Contributor

roiLeo commented Sep 1, 2022

wait what? why this way?
My suggestion would be to manage a new branch and cherry-pick new version of landing

@preschian
Copy link
Member Author

preschian commented Sep 1, 2022

wait what? why this way?

I thought this way was easier. but if we already have another simpler solution I will follow it 👍

@preschian
Copy link
Member Author

My suggestion would be to manage a new branch and cherry-pick new version of landing

for this, does it means we have another big branch for a redesign? for example main-redesign

@roiLeo
Copy link
Contributor

roiLeo commented Sep 1, 2022

for this, does it means we have another big branch for a redesign? for example main-redesign

yes! maybe with another branch name, since we're migrating app to use vue3 composition api

@preschian
Copy link
Member Author

yes! maybe with another branch name, since we're migrating app to use vue3 composition api

I thought that with another big branch would be difficult once ready to merge into the main branch, because of some file conflicts

but, no issue for me if everyone prefers that way 👍

@roiLeo
Copy link
Contributor

roiLeo commented Sep 1, 2022

but, no issue for me if everyone prefers that way 👍

Let's wait for another developer's point of view

@yangwao
Copy link
Member

yangwao commented Sep 1, 2022

uno momento 🤌
ill drop wisdom to discussion thread 🧵

@roiLeo
Copy link
Contributor

roiLeo commented Sep 2, 2022

Since we're going to use new typo, different font-size & update components (inputs, select, dropdown) design. I would be in favor to make these developments on a new branch so as not to disrupt the existing one.
I find that it might be difficult to maintain 2 different design system on the same project/branch.

@preschian
Copy link
Member Author

Since we're going to use new typo, different font-size & update components (inputs, select, dropdown) design. I would be in favor to make these developments on a new branch so as not to disrupt the existing one. I find that it might be difficult to maintain 2 different design system on the same project/branch.

maybe describe and define the branch name in here #3710. so on every redesign PR can follow the guideline to that link

@yangwao
Copy link
Member

yangwao commented Sep 2, 2022

I've dropped some wisdom #3710

define the branch name

canary

Since we're going to use new typo, different font-size & update components (inputs, select, dropdown) design. I would be in favor to make these developments on a new branch so as not to disrupt the existing one.

just for the landing page, I promise 🤞🥹

@preschian
Copy link
Member Author

ready for review 🙏🏻

it's decided that we use query parameters for the landing page only #3710 (reply in thread). the goal is still the same, hopefully not break/block the existing design while creating a new redesign component

@codeclimate
Copy link

codeclimate bot commented Sep 8, 2022

Code Climate has analyzed commit 31f693d and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian requested a review from prachi00 September 8, 2022 05:25
@preschian preschian mentioned this pull request Sep 8, 2022
@yangwao
Copy link
Member

yangwao commented Sep 10, 2022

yas, let's kick this off! :)

works old version and the new one seems div containers ready to be there.

pay 100

@yangwao
Copy link
Member

yangwao commented Sep 10, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 51.94 USD/KSM ~ 1.925 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x926dced7f7648ebc43def691b88111f371532bafea39338a1ee731110078a9a4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 10, 2022
@yangwao yangwao merged commit d3a6ca1 into main Sep 10, 2022
@yangwao yangwao deleted the prepare-layout-new-design branch September 10, 2022 10:30
@yangwao yangwao mentioned this pull request Sep 12, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants