Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 identity balance #4999

Merged
merged 5 commits into from
Feb 17, 2023
Merged

🔧 identity balance #4999

merged 5 commits into from
Feb 17, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Feb 14, 2023

⚠️ hotfix to prod

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

snek
Screenshot 2023-02-14 at 13-15-38 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

bsx
Screenshot 2023-02-14 at 13-15-51 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner February 14, 2023 12:21
@roiLeo roiLeo requested review from vikiival and Jarsen136 and removed request for a team February 14, 2023 12:21
@netlify
Copy link

netlify bot commented Feb 14, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit d679454
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ef37a57a0bd30008944eb5
😎 Deploy Preview https://deploy-preview-4999--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 14, 2023

@vikiival might need you help here, any idea why pallet version changed? is it from new snekk release?

@cryptodamsky you should be able to mint on this preview

@vikiival
Copy link
Member

@vikiival might need you help here, any idea why pallet version changed?

possible

@vikiival
Copy link
Member

Looks correct on BSX

Screenshot 2023-02-14 at 13 42 43

@vikiival
Copy link
Member

On Kusama

Screenshot 2023-02-14 at 13 47 55

@roiLeo
Copy link
Contributor Author

roiLeo commented Feb 14, 2023

hmm... not sure what should I be looking at

@codeclimate
Copy link

codeclimate bot commented Feb 17, 2023

Code Climate has analyzed commit d679454 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@vikiival vikiival merged commit 45a66f7 into kodadot:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival approved these changes

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unintuitive minting fee process on BSX / KSM
2 participants
@roiLeo @vikiival