Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use dynamic grid on existing explorer #5137

Merged
merged 2 commits into from
Mar 1, 2023
Merged

feat: use dynamic grid on existing explorer #5137

merged 2 commits into from
Mar 1, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Mar 1, 2023 •
edited by yangwao
Loading

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@preschian
Copy link
Member Author

on this PR apply a dynamic grid on the existing explorer page
demo:

cc @exezbcz @yangwao

Base automatically changed from feat/dynamic-grid to main March 1, 2023 08:33
@preschian preschian marked this pull request as ready for review March 1, 2023 09:07
@preschian preschian requested a review from a team as a code owner March 1, 2023 09:07
@preschian preschian requested review from vikiival and Jarsen136 and removed request for a team March 1, 2023 09:07
@netlify
Copy link

netlify bot commented Mar 1, 2023 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 47878c6
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63ff15e410d1d0000832fdb6
😎 Deploy Preview https://deploy-preview-5137--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Mar 1, 2023

Code Climate has analyzed commit 47878c6 and detected 0 issues on this pull request.

View more on Code Climate.

Jarsen136
Jarsen136 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

Good to go for and ETHDENVER

@yangwao yangwao added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked S-visual-ok-✅ labels Mar 1, 2023
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

pay 50 usd

@yangwao yangwao merged commit 8d3e659 into main Mar 1, 2023
@yangwao yangwao deleted the feat/dynamic-grid-on-collection-list branch March 1, 2023 15:15
@yangwao
Copy link
Member

yangwao commented Mar 1, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 37.68 USD/KSM ~ 1.327 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x89058f98fbc8aa0f79eeb2f947351175869b257d4d5bcc4a9827b187a71ba7b6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@vikiival vikiival Awaiting requested review from vikiival vikiival is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@preschian @yangwao @Jarsen136