-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(transfer token switch): Refactor for token switching at transfer #6895
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request consists of three patches. The first patch refactors the handling of tokens and crosschain tokens in multiple components and utilities, mainly focusing on improving the calculation and formatting of balances. Key changes include moving the The second patch fixes balance issues within the The third patch refines previous changes and removes unneeded variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small stuff
sometimes the page gets refreshed, sometimes it doesn't, most times the selected asset gets to be the first in order, but not all the time(check KSM behavior) position.mp4 |
@prury to remove the refresh as mentioned we have to get rid of the prefix inside the url , the whole state will rerender on route change , tabs included , that's why sometimes is first (route change), is not first just changing token on the same network where is not changing networks is when a token is available also inside that chain like KSM on bsx
thanks waiting on feedback @Jarsen136 @vikiival |
This reverts commit 1aa97df.
@prury could you have a look, please? 👀 |
ok here we go @Jarsen136 removed all traces of code that is not used (basically all related to mutlichain tokens), pls review last one 🤞 @prury pls verify that all works @preschian need a review :D |
Code Climate has analyzed commit cdc383a and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@prury try now |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
@yangwao payout failed |
pay 50 usd |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at b2fdb6b
This pull request adds support for multiple balances and tokens across different chains for the NFT gallery. It refactors and enhances several components and composables to use chain and token data and utilities from external modules, and to handle the token selection and validation logic. It also removes some unused code and improves code reusability and consistency. The main files affected are
MultipleBalances.vue
,Money.vue
,Transfer.vue
,useToken.ts
,useBalance.ts
,chain.ts
, andidentity.ts
.🤖 Generated by Copilot at b2fdb6b