Refactor: CreateCollection

[stephenjason89]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

1st issue is the component registration, while dynamic import (lazy-loading) component registration in this syntax works on nuxt-bridge, it doesn't work on nuxt 3.

2nd issue is the unnecessary re-registration of watcher inside a submit function. This may cause bugs or may affect performance. Everytime the function is run, another watcher watching the same reactive reference & doing the same logic is created.

This issue is also present in

• bsx/Create/CreateToken.vue
• collection/drop/DropContainer.vue
• rmrk/Create/CreateCollection.vue
• rmrk/Create/CreateToken.vue
• stmn/Create/CreateCollection.vue

Do we want to this changes and change all the above files as well?

PR Type

• Bugfix
• Feature
• Refactoring

Context

• Closes Refactor bsx/Create/CreateCollection.vue #6959
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Community participation

• Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 5621f42

Refactored component imports and added feedback for collection creation in CreateCollection.vue.

🤖 Generated by Copilot at 5621f42

To make the code more compact
Some components are imported direct
And when you create
A collection, you'll see
A feedback message that's perfect

[kodabot]

SUCCESS @stephenjason89 PR for issue #6959 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	5621f42
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64e9f63fa7b0640008aace13
😎 Deploy Preview	https://deploy-preview-6968--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request contains two main patches.

The first patch addresses an issue related to incompatible dynamic import component registration on Nuxt 3. The dynamic imports previously being used have been replaced with static imports for a handful of components, including Loader, BaseCollectionForm, SubmitButton etc.

The second patch corrects an issue which led to the unnecessary re-registration of a watcher inside the submit function, potentially causing bugs. The watcher has been moved out of the submit function and is directly defined within the Vue component, effectively streamlining this process. These corrections contribute to overall performance optimization and bug prevention.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[prury]

#7016 preventing me from testing

[daiagi]

I think this PR has been made redundant by

• refactor: unify create collection #6974

[stephenjason89]

I think this PR has been made redundant by

• refactor: unify create collection #6974

That looks good. It's better to unify them all as it is indeed redundant