Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/title tag #6993

Merged
merged 27 commits into from
Aug 28, 2023
Merged

Chore/title tag #6993

merged 27 commits into from
Aug 28, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Aug 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

yes $

Copilot Summary

🤖 Generated by Copilot at e0b95bb

This pull request refactors the script syntax and adds SEO metadata for several pages in the kodadot/nft-gallery repository. The changes aim to improve the code readability, error-resistance, and user experience. The pages affected include e2e-login.vue, drops/index.vue, explore/collectibles.vue, explore/items.vue, massmint/index.vue, massmint/onboarding.vue, teleport.vue, ahk/create.vue, ahk/waifu.vue, ahp/create.vue, bsx/assets.vue, bsx/claim.vue, bsx/create.vue, bsx/incomingOffers.vue, bsx/offers.vue, bsx/stats.vue, bsx/waifu.vue, carbonless.vue, cookie-notice.vue, and error.vue.

🤖 Generated by Copilot at e0b95bb

We're the masters of the code, we make the pages shine
We optimize the SEO, we tweak the head and title
We refactor and improve, we use the export default
We're the rebels of the web, we create carbonless NFTs

Summary of title changes

https://docs.google.com/spreadsheets/d/1PVbyu9nQiTlFLEVjPxyPkGP4kIyXoniZfe2yZf_YJgM/edit?usp=sharing

@daiagi daiagi requested a review from a team as a code owner August 28, 2023 03:55
@daiagi daiagi requested review from stephenjason89 and roiLeo and removed request for a team August 28, 2023 03:55
@kodabot
Copy link
Collaborator

kodabot commented Aug 28, 2023

SUCCESS @daiagi PR for issue #6957 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a87f78f
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ec1cf84105ad00072f8ccc
😎 Deploy Preview https://deploy-preview-6993--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 28, 2023

AI-Generated Summary: This pull request includes significant changes to several .vue files to improve SEO. The changes encompass updates to associated meta tags, description, and title information for pages like /pages/drops, /pages/explore/collectibles, /pages/explore/items, among others. It also improves alt text for image tags, provides better access to social media links from QR codes, and adds more informative page descriptions. The login page for testing and development purposes now also includes a noindex, nofollow instruction for web robots. Overall, these updates enhance the accessibility and search engine optimization of the website.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Aug 28, 2023
pages/carbonless.vue Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.9% 1.9% Duplication

@codeclimate
Copy link

codeclimate bot commented Aug 28, 2023

Code Climate has analyzed commit a87f78f and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

I think good shots! important was have some as ahref suggested it's downranking our quality of site

pay 70 usd

@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.44 USD/DOT ~ 15.766 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x81e2b9c8ac7c06c8d6a2680712f4673280ada3836bd201c85e760061ae2b1bdc

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 28, 2023
@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

😍 Perfect, I’ve sent the payout
💵 $70 @ 4.44 USD/DOT ~ 15.766 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x02866ce2c7cfd4231ec379637077272b8d2796a2233112a71d909c7f409e74e9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

keep bonus @daiagi for creativity! :D

editing why there is no label seems trigger race condition

@yangwao yangwao merged commit 7bc6185 into main Aug 28, 2023
@yangwao yangwao deleted the chore/title-tag branch August 28, 2023 10:05
@daiagi daiagi mentioned this pull request Aug 29, 2023
10 tasks
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large paid pull-request has been paid waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title tag missing or empty
3 participants