Fix/copies-on-basilisk

[daiagi]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

• Bugfix
• Feature
• Refactoring

Needs QA check

• @kodadot/qa-guild please review
• testing is possibly blocked by Balance issues on Create collection and Create Token in Basilisk #6995

Context

• Closes Copies don't work on Basilisk #6918
• fixes an unreported bug: royalty didn't work

https://basilisk.subscan.io/extrinsic/4090104-2
https://canary.kodadot.xyz/bsx/gallery/3103123271-2

Did your issue had any of the "$" label on it?

• My DOT address: Payout

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at d6fcb30

This pull request improves the functionality and user experience of minting multiple tokens on Basilisk and Statemine networks. It renames the edition field to copies and sets a default royalty recipient. It also refactors the code to use a common expandCopies function from the utils module to generate the tokens array.

🤖 Generated by Copilot at d6fcb30

Sing, O Muse, of the skillful coder who refines his craft
With expandCopies, a function of great utility and power
That multiplies the tokens with their names and metadata
And sends them forth to mint on different networks with ease.

[kodabot]

SUCCESS @daiagi PR for issue #6918 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	2c7dc08
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64ec51749ca2760008f4a391
😎 Deploy Preview	https://deploy-preview-6996--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request consists of two distinct modifications to a Vue component and several TypeScript modules.

In the first patch, changes are made to CreateToken.vue. The 'edition' ref variable and related calculation is replaced by 'copies'. Also, a small line of code which sets 'accountId.value' as the value of the 'address' field in 'royalty' ref, has been added.

The second patch deals with the utilisation of a function called expandCopies. A stray backslash symbol is deleted from CreateToken.vue. The expandCopies() function, previously housed in transactionMintStatemine.ts, is moved to utils.ts and then imported back into both transactionMintBasilisk.ts and transactionMintStatemine.ts. The difference from the original function handling is that it is now used within the getArgs() function in the transactionMintBasilisk.ts file. This function is used to create a deeper copy of tokens, handling each 'copy' as a separate token. The impact of this pull request appears to be the handling of multiple token copies and enhancing modularity by moving the expandCopies() function to a shared utility file, utils.ts.

[codeclimate]

Code Climate has analyzed commit 2c7dc08 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[prury]

tried to mint something, but nothing happened: https://basilisk.subscan.io/tx/0xc1c032d4180d53237cd75ea38e847282b5f08804fcd124fb3e2726fda4a876ab

but seems that basilisk is specially slow today, will wait to see what happens

[daiagi]

tried to mint something, but nothing happened

The transaction seems successful , do you not see the nfts in your account?

[prury]

tried to mint something, but nothing happened

The transaction seems successful , do you not see the nfts in your account?

https://deploy-preview-6996--koda-canary.netlify.app/bsx/gallery/282897835-3
yes, i do not, but can be unrelated

[daiagi]

I'll check your transaction more deeply and compare with mine.
In brief look it seems everything is alright and should be working

It did work for me, tested only once

[prury]

I'll check your transaction more deeply and compare with mine. In brief look it seems everything is alright and should be working

It did work for me, tested only once

went to canary to mint something on this same collection and this message appears:

so, it seems that the space had been taken, but no nft

[prury]

yes, we are probably having issues with basilisk atm, went to create a collection using canary and after some minutes it still won't show on my created collections list

https://basilisk.subscan.io/tx/0xf40c9239d98ad6129974033863811f717bd067df1a03b26b0ce2ccc7db215d03

[daiagi]

yes, we are probably having issues with basilisk atm, went to create a collection using canary and after some minutes it still won't show on my created collections list

Yes I'm experiencing the same while testing

• refactor: unify create collection #6974
  something wrong with Basilisk

successful transaction:

https://basilisk.subscan.io/extrinsic/4098003-2

nothing shows:

[prury]

#7016 preventing us from testing

[prury]

working fine @daiagi
https://deploy-preview-6996--koda-canary.netlify.app/bsx/collection/282897835

[yangwao]

pay 50 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.58 USD/DOT ~ 10.917 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x90a9b9edaf26bb7ab53000440334467cc3a74d12dd517238887b4cd2bae8b4ed

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[daiagi]

Hi @yangwao
Transaction failed

[roiLeo]

@Jarsen136 Tests fails here too (#6990 (review))

[yangwao]

pay 50 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.48 USD/DOT ~ 11.161 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xb0561d175fdc8791f5bafd966711104665bb94e8d11c947218c562e7794792b6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues