feat: confirmation modal for mint #7241

xiiiAtCn · 2023-09-11T13:56:22Z

PR Type

Bugfix
Feature
Refactoring

Context

Closes Confirmation modal for minting and small things #7169
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

my DOT address: Payout

Community participation

Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

Copilot Summary

`🤖 Generated by Copilot at ff3ebfe`

This pull request adds confirmation modals for minting collections and tokens in the create section of the NFT gallery. It also adds new components and translation keys to display the minting information and fees. The files affected are CreateCollection.vue, CreateToken.vue, en.json, ConfirmMintItem.vue, MintConfirmModal.vue, and PriceItem.vue.

`🤖 Generated by Copilot at ff3ebfe`

Sing, O Muse, of the crafty code that the heroes wrought
To mint the shining tokens of their skill and art,
With ConfirmMintItem.vue and MintConfirmModal.vue they brought
The fee and image of each NFT to the user's heart.

kodabot · 2023-09-11T13:56:26Z

SUCCESS @xiiiAtCn PR for issue #7169 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2023-09-11T13:56:27Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`aa62e8a`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6523e6d20ad3860008bc4784
😎 Deploy Preview	https://deploy-preview-7241--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-09-11T13:57:00Z

AI-Generated Summary: This pull request introduces a significant number of changes centered around the creation of new Vue components and the modification of existing ones. These new components ConfirmMintItem.vue, CreateCollection.vue, MintConfirmModal.vue, PriceItem.vue are related to minting process improvements, and handling the modal layout of certain user actions. Changes made in CreateToken.vue and locales/en.json provide additional functionalities and translations for different operations related to minting. Additionally, the patch shows the creation of multiple Vue templates with associated scripts and styles. The changes made in CreateCollection.vue and CreateToken.vue integrate the new components into the process of creating a collection and token respectively. The important modification made is enabling the confirmation of mint in the components. The MintConfirmModal.vue and PriceItem.vue components get updated with new functionalities and UI improvements. The update includes adding information about currency used in respective components, adding clickable chevrons for better UI/UX, handling the display of fees on the basis of certain conditions, and adding information icons for explaining certain functionalities.

exezbcz · 2023-09-15T09:42:32Z

hello, will leave the majority of the review for devs. Few bits from me:

make the whole text with the dropdown clickable, plus the cursor pointer

tooltip should popup when you hover over the text as well - making the area bigger

xiiiAtCn · 2023-09-15T10:52:08Z

make the whole text with the dropdown clickable, plus the cursor pointer

tooltip should popup when you hover over the text as well - making the area bigger

okay. Work almost done.
Understanding these fees cost much time for a newbie

exezbcz · 2023-09-15T11:08:30Z

make the whole text with the dropdown clickable, plus the cursor pointer

tooltip should popup when you hover over the text as well - making the area bigger

okay. Work almost done.
Understanding these fees cost much time for a newbie

Yeah but at least he finally knows what is he paying and what is required

xiiiAtCn · 2023-09-15T22:14:21Z

Yeah but at least he finally knows what is he paying and what is required

Can't agree more. Cause I'm the one😃

yangwao · 2023-10-09T10:12:09Z

Thank you for your work @xiiiAtCn, sending at least some fair payout
pay 50 usd

Seems @xiiiAtCn is MIA
Can you @preschian please take over, resolve conflicts and merge it?
Thanks

yangwao · 2023-10-09T10:12:21Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 3.86 USD/DOT ~ 12.953 $DOT
🧗 12jXHf7yYF4wTRjDPbwFB24V1nVRPRkuU2S8Ke5ZWTfvyBGW
🔗 0x384530c0fa22e20ea256fae4c39ea437711a58b88233a9fb107a52eb4eb8f3ad

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

* * The following components have been removed: * - components/bsx/Create/CreateToken.vue * - components/rmrk/Create/CreateToken.vue * - components/stmn/Create/CreateToken.vue

* feat(CreateNft.vue): add support for process.env.PORT environment variable * chore(CreateNft.vue): remove unused import in CreateNft.vue * feat(CreateNft.vue): add logic for creating and listing NFTs * feat(CreateNft.vue): add logic for getting NFT ID

…t above MintConfirmModal component * chore(CreateNft.vue): rearrange code to move Loader component above MintConfirmModal component

…n/7241

* refactor(CommonTokenMoney.vue): Remove unused imports and variables

… and displayUnit * fix(Money.vue): fix formatting of finalValue in round function

…and PriceItem.vue to the Confirm directory * fix(confirm): fix import paths in CreateCollection.vue and CreateNft.vue * feat(confirm): add toggleConfirm function to toggle the confirmation modal * feat(confirm): update createNft function to toggle the confirmation modal

codeclimate · 2023-10-09T11:41:50Z

Code Climate has analyzed commit aa62e8a and detected 0 issues on this pull request.

View more on Code Climate.

prury · 2023-10-09T21:51:24Z

On KusamaHub it says that i don't have enough to mint, even though i have:

same for Kusama, i believe its related to mint settings, since deactivating koda mint costs lets me proceed with the transaction

…n/7241

netlify · 2023-10-10T04:38:47Z

✅ Deploy Preview for nuxt-kodadot ready!

Name	Link
🔨 Latest commit	`5531657`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt-kodadot/deploys/65251fafdab2f7000891d599
😎 Deploy Preview	https://deploy-preview-7241--nuxt-kodadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

preschian · 2023-10-10T04:48:38Z

On KusamaHub it says that i don't have enough to mint, even though i have:
same for Kusama, i believe its related to mint settings, since deactivating koda mint costs lets me proceed with the transaction

updated

exezbcz · 2023-10-10T06:08:30Z

Should it not be "on" Kusama hub?

otherwise works for me! thanks for completing

* fix(en.json): update "notEnoughFund" message to include the platform name * fix(en.json): fix typo in "existing" key

…n/7241

sonarqubecloud · 2023-10-10T09:56:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

xiiiAtCn added 3 commits September 11, 2023 18:54

modal layout

75796f6

tmp: add question icon

42d13b1

tmp: check data source

ff3ebfe

reviewpad bot added the large Pull request is large label Sep 11, 2023

xiiiAtCn and others added 12 commits September 12, 2023 17:55

tmp: add i18n

7593536

Merge branch 'main' into feat_mint-confirm-modal

aa21f9c

tmp: remove unused import

1d364f8

tmp: calculate deposit fee

e9d404f

Merge branch 'main' into feat_mint-confirm-modal

da49ccf

feat: add fee in collection create modal

bde8973

fix: wrong token unit

b91bfa6

create collection modal

85b38db

nft mint modal in ksm

4b31560

fix: remove unused code

f73b2fa

Merge branch 'main' into feat_mint-confirm-modal

d14718b

fix: submit btn text

7844f14

fix: correct deposit

1864da4

xiiiAtCn and others added 5 commits September 18, 2023 14:36

Merge branch 'main' into feat_mint-confirm-modal

43a145a

format tooltip

0e293c5

feat: add mint confirm modal

0a5420f

feat: add custom class for submit button

10f7da0

use global css

36a163e

xiiiAtCn marked this pull request as ready for review September 18, 2023 10:24

yangwao added the paid pull-request has been paid label Oct 9, 2023

preschian added 7 commits October 9, 2023 17:27

* chore: remove unused CreateToken.vue components

d1a9fd5

* * The following components have been removed: * - components/bsx/Create/CreateToken.vue * - components/rmrk/Create/CreateToken.vue * - components/stmn/Create/CreateToken.vue

* chore(CreateCollection.vue): rearrange code to move Loader componen…

2819674

…t above MintConfirmModal component * chore(CreateNft.vue): rearrange code to move Loader component above MintConfirmModal component

Merge branch 'main' of github.com:kodadot/nft-gallery into pr/xiiiAtC…

d265ad5

…n/7241

* refactor(TokenMoney.vue): Remove unused props and computed properties

db072e1

* refactor(CommonTokenMoney.vue): Remove unused imports and variables

* refactor(Money.vue): refactor computed properties for tokenDecimals…

fceef9c

… and displayUnit * fix(Money.vue): fix formatting of finalValue in round function

preschian requested review from prury and exezbcz October 9, 2023 11:50

exezbcz mentioned this pull request Oct 9, 2023

Migration UI - 2 - Review #7561

Closed

prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Oct 9, 2023

prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Oct 9, 2023

preschian changed the base branch from main to nuxt October 10, 2023 04:16

preschian added 3 commits October 10, 2023 11:20

Merge branch 'nuxt' of github.com:kodadot/nft-gallery into pr/xiiiAtC…

d9395aa

…n/7241

Merge branch 'nuxt' of github.com:kodadot/nft-gallery into pr/xiiiAtC…

547f45f

…n/7241

fix: Fix import path in ConfirmMintItem and MintConfirmModal components

2fec668

exezbcz approved these changes Oct 10, 2023

View reviewed changes

preschian added 2 commits October 10, 2023 16:55

* chore(en.json): remove unnecessary line break

906b3ab

* fix(en.json): update "notEnoughFund" message to include the platform name * fix(en.json): fix typo in "existing" key

Merge branch 'nuxt' of github.com:kodadot/nft-gallery into pr/xiiiAtC…

5531657

…n/7241

yangwao merged commit 8dda3f9 into kodadot:nuxt Oct 10, 2023

exezbcz mentioned this pull request Oct 18, 2023

Unable to finish minting collection #4358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: confirmation modal for mint #7241

feat: confirmation modal for mint #7241

xiiiAtCn commented Sep 11, 2023 •

edited by roiLeo

Loading

kodabot commented Sep 11, 2023

netlify bot commented Sep 11, 2023 •

edited

Loading

reviewpad bot commented Sep 11, 2023

exezbcz commented Sep 15, 2023

xiiiAtCn commented Sep 15, 2023

exezbcz commented Sep 15, 2023

xiiiAtCn commented Sep 15, 2023

yangwao commented Oct 9, 2023

yangwao commented Oct 9, 2023

codeclimate bot commented Oct 9, 2023

prury commented Oct 9, 2023

netlify bot commented Oct 10, 2023 •

edited

Loading

preschian commented Oct 10, 2023

exezbcz commented Oct 10, 2023 •

edited

Loading

sonarqubecloud bot commented Oct 10, 2023

feat: confirmation modal for mint #7241

feat: confirmation modal for mint #7241

Conversation

xiiiAtCn commented Sep 11, 2023 • edited by roiLeo Loading

PR Type

Context

Did your issue had any of the "$" label on it?

Community participation

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at ff3ebfe

🤖 Generated by Copilot at ff3ebfe

kodabot commented Sep 11, 2023

netlify bot commented Sep 11, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

reviewpad bot commented Sep 11, 2023

exezbcz commented Sep 15, 2023

xiiiAtCn commented Sep 15, 2023

exezbcz commented Sep 15, 2023

xiiiAtCn commented Sep 15, 2023

yangwao commented Oct 9, 2023

yangwao commented Oct 9, 2023

codeclimate bot commented Oct 9, 2023

prury commented Oct 9, 2023

netlify bot commented Oct 10, 2023 • edited Loading

✅ Deploy Preview for nuxt-kodadot ready!

preschian commented Oct 10, 2023

exezbcz commented Oct 10, 2023 • edited Loading

sonarqubecloud bot commented Oct 10, 2023

xiiiAtCn commented Sep 11, 2023 •

edited by roiLeo

Loading

`🤖 Generated by Copilot at ff3ebfe`

`🤖 Generated by Copilot at ff3ebfe`

netlify bot commented Sep 11, 2023 •

edited

Loading

netlify bot commented Oct 10, 2023 •

edited

Loading

exezbcz commented Oct 10, 2023 •

edited

Loading