Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: mass listing selector popup #7289

Merged
merged 7 commits into from
Sep 24, 2023
Merged

style: mass listing selector popup #7289

merged 7 commits into from
Sep 24, 2023

Conversation

floyd-li
Copy link
Member

@floyd-li floyd-li commented Sep 18, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
图片

Copilot Summary

🤖 Generated by Copilot at 09f8002

Improved the appearance and alignment of the ListingCartMini component to match the design mockup. Removed unnecessary border and adjusted colors.

🤖 Generated by Copilot at 09f8002

ListingCart styled
Colors, border, position
Harmonize in spring

@floyd-li floyd-li requested a review from a team as a code owner September 18, 2023 06:46
@floyd-li floyd-li requested review from daiagi and Jarsen136 and removed request for a team September 18, 2023 06:46
@kodabot
Copy link
Collaborator

kodabot commented Sep 18, 2023

SUCCESS @floyd-li PR for issue #7175 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Sep 18, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c4f1f1e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6509b382de47a00008576cef
😎 Deploy Preview https://deploy-preview-7289--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 18, 2023

AI-Generated Summary: This pull request includes style modifications to the ListingCartMini.vue component in the common/listingCart directory. The changes include:

  1. Adding a "has-text-grey" class to two NeoButton components to change their text color.
  2. A change in the class for another NeoButton component - switching from "h-full" to "h-full no-border-left", likely altering its size and border property.
  3. Modifications in the .listing-container class in the CSS section, the right and bottom values were adjusted.
  4. A new .no-border-left class is also introduced in the CSS section to remove the left border of an element.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 18, 2023
@daiagi
Copy link
Contributor

daiagi commented Sep 18, 2023

@floyd-li

  1. looks like the fonts are bigger than what required in the issue
  2. please move no-border-left to global.scss

@daiagi daiagi added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 18, 2023
@exezbcz
Copy link
Member

exezbcz commented Sep 18, 2023

after:

image

Should look like this:
image

  • consists of primary buy button
  • height 55px

Please check the height again

@daiagi
Copy link
Contributor

daiagi commented Sep 19, 2023

looks like it's missing an "s"

image

daiagi
daiagi approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other then the "s"
lgtm

@daiagi daiagi added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Sep 19, 2023
@exezbcz
Copy link
Member

exezbcz commented Sep 19, 2023

@daiagi 1 item - list item

@daiagi
Copy link
Contributor

daiagi commented Sep 19, 2023

@exezbcz
image

@prury
Copy link
Member

prury commented Sep 19, 2023

other than the S, is also missing the "|" between select all and clear all

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 19, 2023
@floyd-li
Copy link
Member Author

other than the S, is also missing the "|" between select all and clear all

all updated, including pluralization detection

@prury
Copy link
Member

prury commented Sep 19, 2023

@exezbcz what about hover effect on Clear all and select all? is it supposed not to have any in this modification?

@exezbcz
Copy link
Member

exezbcz commented Sep 19, 2023

@prury should change to the text color, following the system we have in the app

@codeclimate
Copy link

codeclimate bot commented Sep 19, 2023

Code Climate has analyzed commit c4f1f1e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Sep 19, 2023
@exezbcz
Copy link
Member

exezbcz commented Sep 23, 2023

smooth, sorry for the delay, oki for me thanks!

@floyd-li floyd-li mentioned this pull request Sep 23, 2023
Closed
@yangwao
Copy link
Member

yangwao commented Sep 24, 2023

pay 30 usd

@yangwao yangwao merged commit 98d4d0a into kodadot:main Sep 24, 2023
@yangwao
Copy link
Member

yangwao commented Sep 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.05 USD/DOT ~ 7.407 $DOT
🧗 13rv1SWoLg9Gb3tmvHPZxb7JbVy51BtMziX7k9WQGSJ7Kp3A
🔗 0x27da486d2a7c1138992530b630c0c580b884dcc949e10d815f3c4b83024c0946

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 24, 2023
This was referenced Sep 24, 2023
Merged
Merged
@prury prury mentioned this pull request Sep 24, 2023
Closed
@roiLeo roiLeo mentioned this pull request Sep 25, 2023
Closed
This was referenced Sep 27, 2023
Merged
Merged
@floyd-li floyd-li deleted the feat/7175 branch October 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mass listing followup - selector popup
7 participants
@floyd-li @kodabot @daiagi @exezbcz @prury @yangwao @Jarsen136