Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta update #7428

Merged
merged 101 commits into from
Sep 30, 2023
Merged

beta update #7428

merged 101 commits into from
Sep 30, 2023

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Sep 30, 2023

🤖 Generated by Copilot at 1b438c0

This pull request adds new features, UI improvements, validations, and refactors to various components and files related to creating, displaying, and listing NFTs and collections. Some of the main changes are:

@yangwao yangwao added the beta label Sep 30, 2023
@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1b438c0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65181641b45e510008e41fff
😎 Deploy Preview https://deploy-preview-7428--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for koda-beta ready!

Name Link
🔨 Latest commit 1b438c0
🔍 Latest deploy log https://app.netlify.com/sites/koda-beta/deploys/65181641d6bf6100084e3944
😎 Deploy Preview https://deploy-preview-7428--koda-beta.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security
Copy link

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
vitest 0.34.5 filesystem, shell, environment +4 12 MB oreanno
eslint 8.50.0 filesystem, environment +0 2.96 MB eslintbot
@playwright/test 1.38.1 eval, network, filesystem, shell, environment +1 7.14 MB aslushnikov
histoire 0.17.0...0.17.2 None +2/-2 5.63 MB akryum
sass 1.67.0...1.68.0 None +0/-0 5.12 MB sassbot

@yangwao yangwao marked this pull request as ready for review September 30, 2023 12:36
@yangwao yangwao requested a review from a team as a code owner September 30, 2023 12:36
@yangwao yangwao requested review from roiLeo and Jarsen136 and removed request for a team September 30, 2023 12:36
@yangwao yangwao merged commit 54a8586 into beta Sep 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 30, 2023

AI-Generated Summary: This pull request involves changes to multiple files across the project. Key updates include adding new Vue.js components for creating Non-Fungible Tokens (NFTs), including Preview and Landing pages, and incorporating an audio player functionality. Existing components have been modified, with notable changes in GalleryItem.vue, which now handles audio types more effectively.

Several utility functions have been introduced or updated, like delay() in fetch.ts and isValidAddress() in account.ts file. There have been major refactors in the way NFT media is handled using non-imported, media-specific composables, and it has enhanced the methodology of identifying and displaying audio type media.

Furthermore, stylistic updates to components such as NeoDropdown and NeoButton have been made, improving their versatility and overall appearance, and some SVG resources have been added potentially for use in Audio NFT cards.

The dependencies listed in package.json have also been updated, including major packages like @babel/core, eslint, and sass.

Lastly, the project's test configuration and certain test cases (e.g., CreateCollection) have been updated. Some codebase cleanup occurred, including refactoring, relocating, and deleting unused files (e.g., create.vue files in certain chains).

In sum, this pull request represents a major overhaul of the system's NFT creation process, audio handling, codebase organization and associated tests.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Sep 30, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 30, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants