Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GalleryCard): change column layout #929

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 21, 2021

Draft #928

PR type

  • Feature

Before submitting this PR, please make sure:

  • Code builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've didn't break any original functionality
  • I've posted screenshot of demonstrated change in this PR

Optional

  • I've tested it on mobile and everything works
  • I found edge cases

What's new? (may be part of changelog)

Screenshot

Profile

Screenshot 2021-10-21 at 09-54-22 NFT Artist Profile on KodaDot

Collection

Screenshot 2021-10-21 at 09-53-50 KuCodingArts

@roiLeo roiLeo marked this pull request as draft October 21, 2021 07:56
@yangwao
Copy link
Member

yangwao commented Oct 21, 2021

Actually would be good to icon represent expectations after clicking the button.
So whenever we plan to keep 3 cols, to should be 3 and if 5 probably 5 OR
have other icon which says in concept more or less columns, let's surf font awesome shop! :D

image

@roiLeo roiLeo marked this pull request as ready for review October 25, 2021 07:06
@yangwao
Copy link
Member

yangwao commented Oct 25, 2021

I would play a bit with breakpoints
image

@yangwao
Copy link
Member

yangwao commented Oct 28, 2021

okay removing one works for me, nice!

@yangwao yangwao merged commit 323e75a into kodadot:main Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants