-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 initial version of constants for kodadot #110
Conversation
Please if I forgot something, pls let me know. |
gh workflow won't work inside Not sure if it's a good idea to centralized config in a fixed package version. What would be the steps if we need to make a quick update on relay chain because one of them is dead? (same stuff for squid version upgrade/downgrade) |
fixed in #111
Not sure what you mean? |
Let's say new squid rmrk2 (rc1) out, to make progress on developments we will have to wait for a new package release. or I extrapolate a bit |
The intention of the package is to make some constants Second things is that we have a ton of obsolete code on the frontend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I only know two methods to address this
|
@preschian @roiLeo if it makes more sense for you i can move it under the nft-gallery so it will be awailable directly in the workspace. I just need these constants across the other packages (uniquery, vuex-options) WDYT? |
hhmm, maybe try this first? and let's see what happens next |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?