Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMRK V2 #91

Merged
merged 183 commits into from
Apr 4, 2023
Merged

RMRK V2 #91

merged 183 commits into from
Apr 4, 2023

Conversation

vikiival
Copy link
Member

  • feat: types for rmrk2.0 interaction
  • feat: testing for LOCK and ACCEPT
  • feat: add types for rmrk2.0.0 interactions
  • feat: revert rmrk1.0 test file
  • feat: types for json field
  • feat: unwrap for v2 new implementation
  • feat: testing suit for rmrk2.0
  • feat: update field parser
  • feat: reset skip
  • fix: mis deleted line
  • refactor: rename types
  • refactor: move v2 code
  • feat: BUY
  • ref: interaction constants and type
  • feat: V2 EMOTE
  • feat: send list changeissuer
  • fix: remove skip
  • feat: CREATE
  • feat: MINT
  • feat: BURN
  • feat: create InteractionV2
  • feat: colleciton and nft types
  • fix: add ACCEPT and missing field
  • refactor: using same field name with rmrk standard
  • refactor: using same field name with rmrk standard
  • feat: create Interaction
  • feat: test for create interaction
  • feat: create collection
  • feat: create nft
  • feat: type for BASE entity
  • feat: create BASE
  • fix: expected test should be false
  • refactor: check props for createCollection
  • feat: sync test cases
  • feat: error for create interaction
  • fix: rename types and solidator
  • fix: clean types
  • fix: export all in one
  • 🚚 🧪 reorder tests
  • 🚚 moved v2 mocks into correct folder
  • 🐛 unreachable part of code
  • 📝 do not forget
  • 🐛 use same types
  • 🏷️ Abstract NFT type
  • ⚡ V2 impl of some functions
  • 🧪 createCollection use new params
  • 🐛 transferable is binary only in v1
  • 🏷️ use type for created NFT
  • ⚡ use parameters for createNFT v2
  • 🙈 suite is good for small scripts
  • 🏷️ Base has proper type
  • ⚡ lower trim for base
  • 🚚 basic part
  • 🚚 rename parts
  • ⚡ toLowerCase
  • ⚡ makeBaseSymbol
  • 🚚 CreatedBASE to CreatedBase
  • ⚡ somethign
  • 🏷️ Ipfs Uri type
  • 🏷️ a bit of magick with Base
  • 🧼 optimized imports for create
  • 🐛 teplate literal are unknown to this version of typescript
  • 🐛 🙈 some residuals from merging
  • 🧪 create/v2
  • 🧼 🧪 polished tests
  • 🧼 linted RMRK v2
  • ⚰️ no more jest
  • 🧼 linted RMRK v1
  • 🔧 lint-fix
  • 🧼 🧪 polished tests
  • 🐛 Symbol cannnot use - or .
  • 🔧 tests without lint
  • 🐛 base symbol should be lowercased and underscored
  • 🔧 test without coverage
  • 🧪 create passes
  • 🚚 named exports only
  • 🚧 🚚 moving code into packages
  • 🚧 🚚 shuffling types
  • 🚧 🚚 shuffling types v2
  • 🏷️ interactions are under file enumes
  • ⚡ beatutiful unwrap
  • 🏷️ Beatutiful types
  • 🚧 🚚 shuffling types
  • 🎉 shared created called make
  • ⚡ using make as abstraction for create
  • ⚡ make Interaction can has generic meta parametert
  • ⚡ create in V1 logically creates v1 interaction
  • ⚡ code will throw on max < 0
  • ⚡ code will throw on max < 0
  • ⚡ check if string is emppty
  • 🚚 moved identification to shared
  • 🧪 🚚 shuffling
  • 📦 updating exports
  • 🔧 add compatible subpath imports, Close Export Minimark as subpackages #57
  • 🔧 pack
  • @rmrk-team tools
  • 🚧 🧪 testiing
  • 🐛 treat base symbol as UPPERCASED
  • ⚡ base symbol should be always lowercased YOLO
  • 🧪 unconsolidated cases in symbol
  • 🧪 magick

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Fix
  • Feature
  • Refactoring
  • Chore

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR
  • I've written some unit tests 🧪

Optional

  • I found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

@vikiival vikiival marked this pull request as ready for review March 23, 2023 17:28
vikiival added 11 commits March 23, 2023 18:30
…tation token). If positive integer, item will be transferable from that BLOCK onward, e.g. 1400000 means item can be traded after block 1400000. If negative integer, item will be transferable for that many blocks and then become non-transferable.
Copy link
Member Author

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uff

@vikiival
Copy link
Member Author

If @roiLeo or @Jarsen136 can check code?
I may forgot something

@vikiival vikiival merged commit e470572 into main Apr 4, 2023
@vikiival vikiival deleted the remarkable-charon branch April 4, 2023 09:11
@vikiival vikiival mentioned this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Minimark as subpackages
5 participants