Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buffer size for rocfft execution info #219

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: buffer size for rocfft execution info #219

merged 3 commits into from
Jan 8, 2025

Conversation

yasahi-hpc
Copy link
Collaborator

Fixes #218

Using a raw pointer to manage the workbuffer. Also we have modified the ScopedRocfftExecutionInfo class into a non-templated class.

@yasahi-hpc yasahi-hpc self-assigned this Jan 8, 2025
@yasahi-hpc yasahi-hpc added the bug Something isn't working label Jan 8, 2025
tpadioleau
tpadioleau previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@tpadioleau tpadioleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note that we could also use a Kokkos::View with the type std::byte.

fft/src/KokkosFFT_ROCM_types.hpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

@tpadioleau Thank you for the review. I will merge this

@yasahi-hpc yasahi-hpc merged commit 7c3aff8 into kokkos:main Jan 8, 2025
20 checks passed
@yasahi-hpc yasahi-hpc deleted the fix-rocfft-buffer-size branch January 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpadioleau tpadioleau tpadioleau approved these changes

Assignees

@yasahi-hpc yasahi-hpc

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work buffer size too big for the rocfft backend
2 participants
@yasahi-hpc @tpadioleau