New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batched serial laswp #2404

Merged

lucbv merged 3 commits into kokkos:develop from yasahi-hpc:fix-batched-serial-laswp

Oct 29, 2024

Contributor

yasahi-hpc commented Oct 28, 2024

This PR aims at fixing some issues related to #2395

Fix include path in batched/dense/src/KokkosBatched_Laswp.hpp
Add tests for incx argument
Fix some comments in tests

Yuuichi Asahi added 3 commits

October 29, 2024 01:43


          fix include path of Impl

387f822

Signed-off-by: Yuuichi Asahi <[email protected]>


          improve batched serial laswp tests

261e8fd

Signed-off-by: Yuuichi Asahi <[email protected]>


          fix comments in Test_Batched_SerialLaswp.hpp

57a2f19

Signed-off-by: Yuuichi Asahi <[email protected]>

lucbv approved these changes

View reviewed changes

Contributor

lucbv left a comment

Okay, the header was obviously a problem, should have caught it in the last PR.
The unit test improvements for strided layouts are good.

lucbv merged commit 7690b22 into kokkos:develop

19 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet