Sptrsv stream test fixes #2444
Merged
Sptrsv stream test fixes #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
added
AT: PRE-TEST INSPECTED
SPTRSV_CUSPARSE algorithm is not supported for streams, so it made no sense to add it to the list of tested algs inside test_sptrsv_streams. The result was tri_solve_streams being a no-op for this algorithm. Somehow, this was not caught until the block algorithm was being used. Also, some minor cleanup of alg enum handling in the sptrsv handle. Use a switch statement with a default to catch unhandled enum vals. print_algorithm should just use the alg string to avoid a duplicated switch/ifelseif chain. StringToSPTRSVAlgorithm was not handling several of the enum vals and also returning strings inconsistent with the strings in return_algorithm_string. Grep revealed no one using this function, so I removed it. I added a check in tri_solve_streams to throw an error if an unsupported alg is used. Signed-off-by: James Foucar <[email protected]>
jgfouca
force-pushed
the
jgfouca/sptrsv_stream_fixes
branch
from
2f57db4 to
24ded58
Compare
ndellingwood
approved these changes
Dec 2, 2024
|
The H100 job failed due to CI issue (not code-related): From the configure_kokkos stage: Blake H100 nightly jobs are still running fine, and there was no issue with the runner setup, I'm not sure is this a container issue? |
vqd8a
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPTRSV_CUSPARSE algorithm is not supported for streams, so it made no sense to add it to the list of tested algs inside test_sptrsv_streams. The result was tri_solve_streams being a no-op for this algorithm. Somehow, this was not caught until the block algorithm was being used.
Also, some minor cleanup of alg enum handling in the sptrsv handle. Use a switch statement with a default to catch unhandled enum vals. print_algorithm should just use the alg string to avoid a duplicated switch/ifelseif chain. StringToSPTRSVAlgorithm was not handling several of the enum vals and also returning strings inconsistent with the strings in return_algorithm_string. Grep revealed no one using this function, so I removed it.
I added a check in tri_solve_streams to throw an error if an unsupported alg is used.
Fixes #2442