Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the package version #2460

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix the package version #2460

merged 1 commit into from
Dec 13, 2024

Conversation

tpadioleau
Copy link
Member

Fixes #2459

@lucbv
Copy link
Contributor

lucbv commented Dec 13, 2024

@tpadioleau why not set the version parameter in the call to PROJECT() on line 35?
Would that fix the issue you are observing?

@tpadioleau
Copy link
Member Author

@tpadioleau why not set the version parameter in the call to PROJECT() on line 35? Would that fix the issue you are observing?

Yes it is a solution, I have updated accordingly

@tpadioleau
Copy link
Member Author

Could it be part of the patch release 4.5.01 ?

@lucbv
Copy link
Contributor

lucbv commented Dec 13, 2024

Thanks, I tried locally on my laptop as well and it looks good so we should go for that. We can definitely ship it in 4.5.01 then. My sense is we can merge it today : )

lucbv
lucbv approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diagnosing and helping us fix this

@lucbv lucbv added bug Cleanup Code maintenance that isn't a bugfix or new feature AT2-CI-APPROVAL Approve CI to run at SNL labels Dec 13, 2024
@lucbv
Copy link
Contributor

lucbv commented Dec 13, 2024

Ah you would need the DCO thing to make things perfect but it all tests well I could give you a pass on that.

@tpadioleau
Fix the package version
e1fde66 
Signed-off-by: Thomas Padioleau <[email protected]>
@tpadioleau
Copy link
Member Author

Ah you would need the DCO thing to make things perfect but it all tests well I could give you a pass on that.

I have amended the commit

@lucbv lucbv added AT2-CI-APPROVAL Approve CI to run at SNL and removed AT2-CI-APPROVAL Approve CI to run at SNL labels Dec 13, 2024
@lucbv lucbv self-requested a review December 13, 2024 17:55
lucbv
lucbv approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucbv lucbv merged commit f23260a into kokkos:develop Dec 13, 2024
18 checks passed
ndellingwood pushed a commit that referenced this pull request Dec 13, 2024
@tpadioleau @ndellingwood
Fix the package version (#2460)
a3b7bbe 
Signed-off-by: Thomas Padioleau <[email protected]>
lucbv pushed a commit that referenced this pull request Dec 24, 2024
@ndellingwood @tpadioleau
Release 4.5.01 (#2468)
6e2ba94 
* Update patch version for 4.5.01

* Fix the package version (#2460)

Signed-off-by: Thomas Padioleau <[email protected]>

* Update changelog

Signed-off-by: Nathan Ellingwood <[email protected]>

* update to 4.4.01 for codeql and docs checks

Signed-off-by: Nathan Ellingwood <[email protected]>

* update master_history.txt

---------

Signed-off-by: Thomas Padioleau <[email protected]>
Signed-off-by: Nathan Ellingwood <[email protected]>
Co-authored-by: Thomas Padioleau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees

@tpadioleau tpadioleau

Labels
AT2-CI-APPROVAL Approve CI to run at SNL bug Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KokkosKernels PACKAGE_VERSION is not set
2 participants
@tpadioleau @lucbv