-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dyn-rank-view in serial trsv #2464
Conversation
@ndellingwood can you give this a review based on what you saw in Trilinos? |
@lucbv @yasahi-hpc , thanks for the PR, I'll launch a build to test intrepid2 |
Compilation of intrepid2 now succeeds, but many tests are failing so some incompatibility still exists, this is a sample output:
|
I am not 100% sure what is wrong, but Trilinos seems to expect out-of-range access If this is the case, we need to remove checks to allow invalid accesses for these tests |
Signed-off-by: Yuuichi Asahi <[email protected]>
Signed-off-by: Yuuichi Asahi <[email protected]>
84fa11b
to
f02c3df
Compare
Thanks @yasahi-hpc , I retested with your changes and kokkos/kokkos@71cae1c (to avoid some other issues unrelated to this PR) and the intrepid2 tests were passing in (clang/15, Serial backend tested) |
@ndellingwood That is nice. Thank you for your help. |
@yasahi-hpc you did all the hard work, thank you for your fast responses and help! |
@ndellingwood Thanks is mine! Hope my feature PRs do not break Trilinos |
Improves #2456
Kokkos::DynRankView
Kokkos::DynRankView
ValueType
as avalue_type
ofViews