Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLAS - ROT: calling appropriate cuBLAS function #2473

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Jan 6, 2025

After changing the rot interface from using all real to a mix of real and complex coefficients, the cuBLAS call needs to be made to {Z,C}rot instead of {Zd,Cs}rot.

After changing the rot interface from using all real to a mix
of real and complex coefficients, the cuBLAS call needs to be made
to {Z,C}rot instead of {Zd,Cs}rot.

Signed-off-by: Luc Berger-Vergiat <[email protected]>
@lucbv lucbv added bug Cleanup Code maintenance that isn't a bugfix or new feature labels Jan 6, 2025
@lucbv lucbv requested a review from vqd8a January 6, 2025 23:06
@lucbv lucbv self-assigned this Jan 6, 2025
@lucbv lucbv mentioned this pull request Jan 6, 2025
Copy link
Contributor

@brian-kelley brian-kelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out locally and it fixed the rot example and blas unit tests.

@ndellingwood
Copy link
Contributor

We need this for the nightly cu* TPL and Trilinos builds as well

Copy link
Contributor

@vqd8a vqd8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lucbv

@lucbv lucbv merged commit f321baf into kokkos:develop Jan 7, 2025
16 of 18 checks passed
@lucbv lucbv deleted the rot_cublas_fix branch January 7, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants