Merge pull request #278 from uliegecsm/rocprofiler-sdk-roctx

feat(roctxconnector): link `rocprofiler-sdk-roctx` as of `ROCm` 6.2

.github/workflows/build-with-kokkos.yml

@@ -22,7 +22,7 @@ jobs:
           - image: rocm/dev-ubuntu-22.04:5.4
             preset: ROCm
             compiler: default
-          - image: rocm/dev-ubuntu-22.04:5.7
+          - image: rocm/dev-ubuntu-22.04:6.3
             preset: ROCm
             compiler: default
     container:

profiling/roctx-connector/CMakeLists.txt

@@ -1,7 +1,16 @@
-find_library(ROCM_ROCTX_LIB roctx64 REQUIRED HINTS $ENV{ROCM_PATH}/lib)
-find_path(ROCM_ROCTX_INCLUDE roctx.h REQUIRED HINTS $ENV{ROCM_PATH}/include/roctracer)
-
 kp_add_library(kp_roctx_connector kp_roctx_connector.cpp)
 
-target_include_directories(kp_roctx_connector PRIVATE ${ROCM_ROCTX_INCLUDE})
-target_link_libraries(kp_roctx_connector PRIVATE ${ROCM_ROCTX_LIB})
+# As of ROCm 6.2, it is recommended to use ROCtx provided by rocprofiler-sdk-roctx
+# instead of the "old" one provided by roctracer.
+#
+# See also: https://rocm.docs.amd.com/projects/rocprofiler-sdk/en/amd-mainline/how-to/using-rocprofv3.html
+find_package(rocprofiler-sdk-roctx CONFIG PATHS $ENV{ROCM_PATH})
+if(rocprofiler-sdk-roctx_FOUND)
+    target_link_libraries(kp_roctx_connector PRIVATE rocprofiler-sdk-roctx::rocprofiler-sdk-roctx)
+else()
+    find_library(ROCM_ROCTX_LIB roctx64 REQUIRED HINTS $ENV{ROCM_PATH}/lib)
+    find_path(ROCM_ROCTX_INCLUDE roctx.h REQUIRED HINTS $ENV{ROCM_PATH}/include/roctracer)
+
+    target_include_directories(kp_roctx_connector PRIVATE ${ROCM_ROCTX_INCLUDE})
+    target_link_libraries(kp_roctx_connector PRIVATE ${ROCM_ROCTX_LIB})
+endif()

profiling/roctx-connector/kp_roctx_connector.cpp

@@ -14,7 +14,11 @@
 //
 //@HEADER
 
+#if __has_include(<rocprofiler-sdk-roctx/roctx.h>)
+#include <rocprofiler-sdk-roctx/roctx.h>
+#else
 #include <roctx.h>
+#endif
 
 #include <cstdint>
 #include <iostream>