add size enforcement and tests #37
Conversation
png.go
Outdated
| return fmt.Errorf("data too big: %d is bigger than %d", dataSize, v0MaxSize) | ||
| } | ||
|
|
||
| func ToPngNoMaxSize(w io.Writer, data []byte) error { |
There was a problem hiding this comment.
Why have this function?
There was a problem hiding this comment.
Because the original ToPng() check the size before generating the PNG and I needed a way to make a PNG that was too large in order to test that receiving party had the same size limit.
There was a problem hiding this comment.
Why? The size check is before any png detection, right? Just send it too much data and check the error type.
There was a problem hiding this comment.
It feels really wrong to bake in functionality we don't want to have a test for if len(data) > V0MaxSize
There was a problem hiding this comment.
I've updated it to just send too much data. Though the test is not "perfect" due to the b64 encoding in various places that changes the size of the data. I don't think I could untangle that with out a bit of a refactor. Which leads me to wonder, do we still need the "boxer" logic at all since v2 relies only on the challenge logic.
There was a problem hiding this comment.
Good question. I wonder how many v1 clients are left. Maybe we should rip it out soon
No description provided.