Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cleanup improvements #2015

Merged
merged 3 commits into from
Jan 28, 2025
Merged

test cleanup improvements #2015

merged 3 commits into from
Jan 28, 2025

Conversation

zackattack01
Copy link
Contributor

@zackattack01 zackattack01 commented Dec 23, 2024 •
edited
Loading

noticed another spot where we were deferring cleanup but then using os.Exit. this just adds explicit removal before exit so the cleanups happen

@zackattack01 zackattack01 added the tests-docs Tests, Docs, and Other No-op Changes label Jan 28, 2025
@zackattack01 zackattack01 marked this pull request as ready for review January 28, 2025 18:01
@zackattack01 zackattack01 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 293162a Jan 28, 2025
32 checks passed
@zackattack01 zackattack01 deleted the zack/more_test_improvements branch January 28, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

Assignees
No one assigned
Labels
tests-docs Tests, Docs, and Other No-op Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackattack01 @RebeccaMahany