presence detection callback #2048
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
James-Pickett
commented
Jan 14, 2025
| @@ -222,6 +226,14 @@ func (e *kryptoEcMiddleware) Wrap(next http.Handler) http.Handler { | |||
| // so just add the session id manually | |||
| context.WithValue(callbackReq.Context(), multislogger.KolideSessionIdKey, kolideSessionId[0]), | |||
| ) | |||
|
|
|||
| // here we want to create an additional callback for presence detection, but it's only going to be valid if we have the session (saml) id | |||
There was a problem hiding this comment.
I assume this is true? maybe ... I dunno, K2 could always look up the request ID
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
James-Pickett
commented
Jan 14, 2025
James-Pickett
commented
Jan 14, 2025
James-Pickett
commented
Jan 14, 2025
| @@ -459,3 +475,110 @@ func (bhr *bufferedHttpResponse) WriteHeader(code int) { | |||
| func (bhr *bufferedHttpResponse) Bytes() []byte { | |||
| return bhr.buf.Bytes() | |||
| } | |||
|
|
|||
| func (e *kryptoEcMiddleware) presenceDetectionCallback(callbackReq *http.Request, cmdReq v2CmdRequestType, challengeBox *challenge.OuterChallenge, kolideSessionId []string) { | |||
There was a problem hiding this comment.
*kryptoEcMiddleware is pretty big. Does this need to hang inside that struct?
| @@ -222,6 +226,14 @@ func (e *kryptoEcMiddleware) Wrap(next http.Handler) http.Handler { | |||
| // so just add the session id manually | |||
| context.WithValue(callbackReq.Context(), multislogger.KolideSessionIdKey, kolideSessionId[0]), | |||
| ) | |||
|
|
|||
| // here we want to create an additional callback for presence detection, but it's only going to be valid if we have the session (saml) id | |||
| presenceDetectionCallbackReq := callbackReq.Clone(context.WithoutCancel(callbackReq.Context())) | |||
There was a problem hiding this comment.
I wonder if the rails side would be easier if we used a different URL. Probably okay to try either way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.