Enable revive's defer rule in golangci-lint #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/revive-defer
branch
from
3330c71 to
7f64d37
Compare
RebeccaMahany
commented
Jan 28, 2025
| ctx, cancel := context.WithTimeout(context.Background(), time.Second*5) | ||
| defer cancel() | ||
| cmd, err := browserLauncher(ctx, actionUri) | ||
| cmd, err := browserLauncher(context.TODO(), actionUri) |
There was a problem hiding this comment.
Can't move a timeout with a defer cancel to a new function because then calling cmd.Start at the end of that function makes it fail immediately. I don't think the timeout is super meaningful here so I've removed it rather than adding a lint exception.
James-Pickett
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#defer in our ruleset, and fixes existing violations.