Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed overwriting the token value during read #50

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

thulasirajkomminar
Copy link
Member

Description

InfluxDB OSS always returns the token value using the GET operation but InfluxDB cloud returns string redacted for the same GET operation. This made the provider to overwrite the actual token in the state. Fixed this by adding token to state only during create and used UseStateForUnknown planModifier instead.

Relations

Closes #49

References

Output from Acceptance Testing

% make testacc

...

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.31%. Comparing base (f6b5455) to head (2914560).
Report is 5 commits behind head on main.

Files Patch % Lines
internal/provider/authorization_resource.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #50   +/-   ##
=====================================
  Coverage   0.31%   0.31%           
=====================================
  Files         11      11           
  Lines       1281    1279    -2     
=====================================
  Hits           4       4           
+ Misses      1277    1275    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thulasirajkomminar thulasirajkomminar merged commit 4760e66 into main Aug 23, 2024
6 of 7 checks passed
@thulasirajkomminar thulasirajkomminar deleted the tk/fix-token branch August 23, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Authentication token value is set to Redacted after next terraform apply
1 participant