Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using turbopack for dev scripts #69

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Stop using turbopack for dev scripts #69

merged 1 commit into from
Feb 3, 2025

Conversation

pokornyd
Copy link
Member

@pokornyd pokornyd commented Feb 3, 2025

Motivation

Turbopack seems to have issues with some loaders when ran on windows, resulting in errors when attempting to run next dev with --turbopack parameter, particularly with image loader. This error was not reproducible on Mac OS.

Removing turbopack parameter from dev scripts for now as it isn't crucial for the sample app.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Fill env variables for any collection, run npm run dev and check that it renders without errors.

@pokornyd pokornyd requested a review from a team as a code owner February 3, 2025 13:54
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ficto-healthtech ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm
ficto-healthtech-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm
ficto-imaging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm
ficto-imaging-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm
ficto-surgical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm
ficto-surgical-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:55pm

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for new-sample-app ready!

Name Link
🔨 Latest commit 7260e3c
🔍 Latest deploy log https://app.netlify.com/sites/new-sample-app/deploys/67a0caab82f2e10008cc9b05
😎 Deploy Preview https://deploy-preview-69--new-sample-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IvanKiral IvanKiral merged commit 0db6ed2 into main Feb 3, 2025
12 checks passed
@IvanKiral IvanKiral deleted the remove-turbopack branch February 3, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants