make: fix corner case in -j / -l handling #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```bash ▸ ./kodev test -vj1 make TARGET= KODEBUG=1 VERBOSE=1 testall T=-v\ -j\ 1 cd base/build/x86_64-pc-linux-gnu-debug/cmake && ninja -v -j\ -l8 all ninja: fatal: invalid -j parameter make: *** [base/Makefile:89: base-all] Error 1 ``` Switch to `MFLAGS`: same value as `MAKEFLAGS` except that it does not contain the command line variable definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to
MFLAGS: same value asMAKEFLAGSexcept that it does not contain the command line variable definitions.This change is