The DualReader can handle only one of them

[koriym]

@koriym Hi, I came to a bug when only annotations or attributes are used. The DualReader can handle only one of them, depending on PHP version.

This caused missing annotations on PHP 8. I think more reliable solution would be class like this one - that reads both annotations and attributes on PHP 8, if available. That's what I expected from DualReader class and that's where it failed my expectations. But maybe there is a better way to do it.

From contributte/apitte#165 (review)

[TomasVotruba]

I can fix it here... shall I send PR?

[koriym]

@TomasVotruba Yes! Thanks. But before that let me explain why I was doing it this way.

[TomasVotruba]

No problem. For us it's only important not to break previous behavior, which now happened.

[koriym]

When supporting PHP8, I assumed that both annotations and attributes would be added as follows.

/**
 * @Foo
 */
#[Foo]
class Fake
{
}

The reason why only one of them is read is for performance. There is no performance loss (PHP source parsing cost) for the dual reader when you start with a mixed library of php7 and php8 attributes and end up with "only" php8 attributes.

This was the way I envisioned it to be used, but I would like to address your case as well.

For this, we need two readers. I would like to change your usage to the default "DualReader" and give the current reader a different name, what do you think?

[koriym]

Hmm, probably not a good idea.
Let's just make your changes, shall we?

[TomasVotruba]

When supporting PHP8, I assumed that both annotations and attributes would be added as follows.

In this case I would expected 2 Foo classes. As in these cases:

/**
 * @Foo
 */
#[Foo]
class Fake
{
}

/**
 * @Foo
 * @Foo
 */
class Fake
{
}

#[Foo]
#[Foo]
class Fake
{
}

They are all equal, just with different syntax.

[TomasVotruba]

Hmm, probably not a good idea.
Let's just make your changes, shall we?

I'm on it 👍 :)

[koriym]

I can fix it here... shall I send PR?

Please do it!