-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnnotationAttributeDualReader that can read both annotations and attributes at the same time #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attributes at the same time
TomasVotruba
changed the title
tv in path combo
Add AnnotationAttributeDualReader that can read both annotations and attributes at the same teime
Jul 8, 2021
TomasVotruba
changed the title
Add AnnotationAttributeDualReader that can read both annotations and attributes at the same teime
Add AnnotationAttributeDualReader that can read both annotations and attributes at the same time
Jul 8, 2021
TomasVotruba
force-pushed
the
tv-in-path-combo
branch
from
July 8, 2021 23:31
075fb3b
to
f7a3ea8
Compare
TomasVotruba
commented
Jul 8, 2021
TomasVotruba
force-pushed
the
tv-in-path-combo
branch
from
July 8, 2021 23:34
f7a3ea8
to
70b6487
Compare
Ready to merge 👍 |
TomasVotruba
force-pushed
the
tv-in-path-combo
branch
from
July 8, 2021 23:38
70b6487
to
15e0448
Compare
TomasVotruba
commented
Jul 9, 2021
TomasVotruba
force-pushed
the
tv-in-path-combo
branch
from
July 9, 2021 15:17
2f7445d
to
8f0c418
Compare
There is one more bug with doctrine/annotations... 🤔 I'm just looking into it |
TomasVotruba
commented
Jul 9, 2021
TomasVotruba
commented
Jul 10, 2021
TomasVotruba
force-pushed
the
tv-in-path-combo
branch
from
July 10, 2021 00:58
76dec79
to
c5dafb4
Compare
TomasVotruba
commented
Jul 10, 2021
f3l1x
reviewed
Jul 12, 2021
I've updated version to use tag, now up and CI running succesfuly 🎉 Ready to merge ✔️ |
Just curious, our project avoid dev deps to speedup compose installations on CI and make dependencies more reliable. When do you plan to release this feature? |
I will call you on the phone. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing the practise in practise and it seems the
DualReader
can only read annotation or attributes, not both at the same time.That's why method like this fails: