Improve performance of apply_update
#272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes use of the newly added `create_empty_corpus` function of the corpus storage, which allows to configure what kind of graph storages the empty corpus should use.
…notationStorage` trait. This allows to provide optimized implementations for ondisk and inmemory implementations with much better performance than the previous generic one. As a downside, **this change it breaks the API backward compatibility** because - the function `get_node_id_from_name()` is removed from the `Graph` struct. Calls to the function can easily be changed to `mygraph.get_node_annos().get_node_ide_from_name()` - usage of `AnnotationStorage<NodeID>` is replaced with the new trait `NodeAnnotationStorage` (which inherits AnnotationStorage) - usage of `AnnotationStorage<Edge>` is replaced with the new trait `EdgeAnnotationStorage` (which inherits AnnotationStorage)
…be added in a graph update
The Graph updates are mostly local (e.g. first a `AddNode` and then `AddNodeLabel` events for the same node) and thus the frequency is not important, but that the node has been touched/created recently.
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.