Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for coverage edges between spans and segmentation nodes #306

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

thomaskrause
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 28 lines in your changes missing coverage. Please review.

Project coverage is 67.19%. Comparing base (781dd89) to head (bc93aad).
Report is 7 commits behind head on main.

Files Patch % Lines
graphannis/src/annis/db/example_generator.rs 89.74% 16 Missing and 4 partials ⚠️
graphannis/src/annis/db/aql/model.rs 88.88% 0 Missing and 6 partials ⚠️
cli/src/bin/annis.rs 0.00% 1 Missing ⚠️
graphannis/src/annis/db/corpusstorage.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   66.93%   67.19%   +0.26%     
==========================================
  Files          77       77              
  Lines       18727    18931     +204     
  Branches    18727    18931     +204     
==========================================
+ Hits        12534    12720     +186     
- Misses       4726     4740      +14     
- Partials     1467     1471       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

All covered nodes of an invalidated node will also be invalidated, so we don't need to implicitly add the edges when collected the covered token of the invalid node.
@thomaskrause thomaskrause merged commit 2ff9a4f into main Aug 20, 2024
14 checks passed
@thomaskrause thomaskrause deleted the feature/transitive-coverage branch August 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant