reolink: fallback if token exchange fails

koush · Jul 6, 2024 · f5c324b · f5c324b
1 parent b7bf995
commit f5c324b
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 34 deletions.
diff --git a/plugins/reolink/package-lock.json b/plugins/reolink/package-lock.json
diff --git a/plugins/reolink/package.json b/plugins/reolink/package.json
@@ -1,6 +1,6 @@
 {
    "name": "@scrypted/reolink",
-   "version": "0.0.81",
+   "version": "0.0.82",
    "description": "Reolink Plugin for Scrypted",
    "author": "Scrypted",
    "license": "Apache",

diff --git a/plugins/reolink/src/probe.ts b/plugins/reolink/src/probe.ts
@@ -60,38 +60,51 @@ export async function getLoginParameters(host: string, username: string, passwor
     catch (e) {
     }
 
-    const url = new URL(`http://${host}/api.cgi`);
-    const params = url.searchParams;
-    params.set('cmd', 'Login');
-
-    const response = await httpFetch({
-        url,
-        method: 'POST',
-        responseType: 'json',
-        rejectUnauthorized: false,
-        body: [
-            {
-                cmd: 'Login',
-                action: 0,
-                param: {
-                    User: {
-                        userName: username,
-                        password: password
+    try {
+        const url = new URL(`http://${host}/api.cgi`);
+        const params = url.searchParams;
+        params.set('cmd', 'Login');
+
+        const response = await httpFetch({
+            url,
+            method: 'POST',
+            responseType: 'json',
+            rejectUnauthorized: false,
+            body: [
+                {
+                    cmd: 'Login',
+                    action: 0,
+                    param: {
+                        User: {
+                            userName: username,
+                            password: password
+                        }
                     }
-                }
+                },
+            ],
+        });
+
+        const token = response.body?.[0]?.value?.Token?.name || response.body?.value?.Token?.name;
+        if (!token)
+            throw new Error('unable to login');
+        const { body } = response;
+        const leaseTimeSeconds: number = body?.[0]?.value?.Token.leaseTime || body?.value?.Token.leaseTime;
+        return {
+            parameters: {
+                token,
             },
-        ],
-    });
-
-    const token = response.body?.[0]?.value?.Token?.name || response.body?.value?.Token?.name;
-    if (!token)
-        throw new Error('unable to login');
-    const { body } = response;
-    const leaseTimeSeconds: number = body?.[0]?.value?.Token.leaseTime || body?.value?.Token.leaseTime;
-    return {
-        parameters: {
-            token,
-        },
-        leaseTimeSeconds,
+            leaseTimeSeconds,
+        }
+    }
+    catch (e) {
+        // if the token exchange fails, fall back to basic auth
+        // TODO: maybe detect error type?
+        return {
+            parameters: {
+                user: username,
+                password,
+            },
+            leaseTimeSeconds: 60,
+        }
     }
 }